Repository navigation
fix(akida2/speech_commands): no hard-coded data path in the data sanity check - #117
Merged
Merged
Conversation
…sanity check The __main__ block of speech_commands_data.py hard-coded a machine-specific dataset path. It now takes -d/--data, defaulting to ./data/speech_commands like the example's other scripts, and moves to the end of the module. Refs HUB-16 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DnyD76hgk85WiSBvfGpN6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs HUB-16
The sanity-check block at the bottom of
akida2/model_zoo/speech_commands/speech_commands_data.pyhard-coded a machine-specific dataset path, whichcheck_content.pyflagged asmachine-path.-d/--data, defaulting to./data/speech_commands, the same default as the example's train, eval and benchmark scripts.get_data, so that function was defined after the script had already run.No change to the training, eval or benchmark paths, so no models, metrics or READMEs change.
Checks
python .claude/skills/review-content/check_content.py: no findings (the machine path was the only one on main).python speech_commands_data.py -d <tfds dir>run end to end on a local Speech Commands TFDS copy: prints a(100, 49, 10, 1)uint8 feature batch and(100,)labels.🤖 Generated with Claude Code
https://claude.ai/code/session_01DnyD76hgk85WiSBvfGpN6w