Repository navigation
Conversation
Issue #192 still needs a founder choice between the canonical encounter and a practice route, so launch behavior is unchanged. Record that AttackPlanner and the OSShell ATTACK icon open topdown with empty roles and do not write encounter consequences. Co-authored-by: BrandDead <BrandDead@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BrandDead
commented
Sep 30, 2026
BrandDead
left a comment
BrandDead
left a comment
Owner
Author
There was a problem hiding this comment.
Read-only integration review: this PR adds a characterization test and project-log note only; it does not correct the ATTACK icon or OPS Planner route. Keep draft pending the founder choice on #192. Issue #193 is actively editing AttackPlanner/TopDownShooter and docs/PROJECT_LOG.md; reconcile that shared log/test behavior after #193 lands, then rerun PR and protected-main gates. Do not treat the 25 focused passes as player-route acceptance or #175 staging proof.
This was referenced Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FOUNDER DECISION: launch behavior is unchanged. This draft scopes the legacy topdown
assignedRolesbypass. It is not the phone-banner or contact-dedupe work, and it is not the button-only GG-002 empty-seat guard.On
main-tL2525(cf05276):OSShellregisters ATTACK asid: 'topdown'.handleAppClickcallsnavigateTo(app.id)with no crew payload.App.renderCurrentAppcase'topdown'rendersTopDownShooter.AttackPlanner.handleLaunchreturns only whenselectedTargetis empty, then callsnavigateTo('topdown').assignedRoles(scout,enforcer,driver) is local state and is not forwarded. There is no shooter field on that object.UnifiedEncounterstays theBlockModeViewpath (handleEncounterResolved→useBlockStore.applyEncounterResult). It was not merged withTopDownShooter.A probe that required this launch to stay off
TopDownShooterfailed: after selecting a target with empty roles,currentAppbecametopdown(expected 'topdown' not to be 'topdown').Issue #192 still asks the founder to choose either the canonical encounter route or a labeled non-authoritative practice route.
TopDownShooteris the seat-assignment screen.canLaunchalready refuses combat until a driver seat, a non-driver seat, and a target are set.endCombatis the only legacy writer for cash, heat, XP, andkillMember, and it does not callapplyEncounterResult. Blocking navigation to that screen would be a new product rule, so this PR does not change it.No second consequence writer, store, or idempotency path was added.
Test
frontend/src/components/missions/AttackPlanner.legacyTopdownRoute.test.tsx(3 passed), plus the existing encounter suiteblockStore.encounter.test.ts,UnifiedEncounterLog.test.tsx, andBlockModeView.test.tsx. 25 passed, 0 failed.tsc --noEmitis clean.The characterization records the current route and that empty roles do not write encounter consequences. It does not pretend a new seat rule.
Rollback
Revert this one commit:
d3aaddd21c9c778f55ea4cc8f588921b36528664.UnifiedEncounteris untouched. No second consequence writer was added. The button-only GG-002 guard is a different PR. Draft PR #157 was not touched.Closes nothing. #192 stays open until the founder picks the route.