Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 3e26873e-e069-494f-a928-b2dfd68b7e59) |
This was referenced Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Existing Flask combat and drive-by sessions are bound to their server-verified creator. Existing-session reads and mutations check that creator before session-derived work, while ordinary creator and offline development flows remain usable.
Scope
In:
backend/python/api/combat.py,backend/python/api/driveby.py, a newbackend/python/tests/test_encounter_session_ownership.py, a dated project-log entry and text verification underdocs/evidence/2026-10-14-session-ownership/.Reserved files: the three backend/test files above; project log is append-only. No frontend/renderer/store or other contributor's branch is changed.
Contracts preserved
Verification
9eef5aa: 12 failed / 12 passed; corrected source: 24 passed.28b2f64b89e854e5f7ccaf9009f5e5e057cf661b. Published exact-head CI passed on8353d53: 1,033 unchanged-frontend tests passed / 4 existing skips; 131 backend tests passed; type/lint/assets/packages/build passed. Vercel preview status is Ready.Limits
These legacy HTTP sessions remain in memory and are separate from the active solo renderer. This does not add live PvP, durable match state, roster authorization or full command validation. #175 live authenticated staging and wider gameplay/release gates remain open. No external-beta or multiplayer-readiness claim is made.
Operational impact
No migration, RLS, credentials, scheduler, production or deployment change. Source rollback is a focused PR revert; no database rollback is needed.
Integration notes
Independent of #206 auth, #204 ATTACK, #205 Nightfall, #202 DRIVE and #169 identity. Preserve all dated project-log additions during integration. Closes nothing. No merge or deployment is requested.
Review availability
Independent local review is complete. GitHub Codex code review is completed; security review is completed. No inline review threads were present at this check. Cursor Bugbot could not run because its usage/spend limit was reached; no budget setting was changed. This is not a merge or release approval.