Repository navigation
refactor: config access is typed, not defensive #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d180b9e
refactor(misc): make_app_config returns a real struct-mode DictConfig…
stanlrt c777651
refactor(model): declare ModelBackend.device; add make_fake_backend (…
stanlrt 119d792
refactor(model): direct config/backend access; type check_backend_com…
stanlrt 7ac9cb7
refactor(misc): direct config access in pipeline; drop dead config.ru…
stanlrt e71ff90
refactor(transparency): direct config/backend access; ModelBackend|No…
stanlrt 473b2b6
refactor(robustness): direct config/backend access; backend.device + …
stanlrt 5385851
refactor(data): direct config access in loaders + metadata (refs #352)
stanlrt 3327f97
refactor(reporting): direct config access, preserve None fallbacks (r…
stanlrt cf36c7a
refactor(metrics): direct config access in metrics/task-family/config…
stanlrt ffb8e20
ci(infra): guard against defensive getattr on typed config/backend (r…
stanlrt 2681450
docs: ADR record for typed config access (refs #352)
stanlrt e3753a6
fix(metrics): guard polymorphic num_classes read; direct data_cfg.inp…
stanlrt 5194760
fix(model): suppress invariant-override on TorchBackend.device narrow…
stanlrt 9da1bbc
fix(model): device via widened helpers not attr-narrowing; restore po…
stanlrt 5a1e520
test(misc): promote integration-test config/backend fakes to real bui…
stanlrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.