change(scripts): verify copied file checksums and skip plots

[zubeydecivelek]

During faser migration I had file checksum mismatch errors, it would be better to verify during copy script and log in case something goes wrong. And if we're skipping plots during migration, no need to copy the plot files.

[kpsherva]

Suggested change

	prefix = "ERROR" if dest_md5 != expected else "SUCCESS"
	if prefix == "ERROR":
	print(
	"ERROR checksum mismatch: recid={} expected={} dest={}".format(
	recid, expected, dest_md5
	)
	)
	checksum_mismatch = dest_md5 != expected
	if checksum_mismatch:
	raise <appropriate error class>(
	"ERROR checksum mismatch: recid={} expected={} dest={}".format(
	recid, expected, dest_md5
	)
	)

I think it should fail if there is something wrong in the file, otherwise it fails silently and puts it in the log. What if I don't check the log?

[kpsherva]

did you come across the checksum mismatch when copying the files or when running the migration?

[zubeydecivelek]

did you come across the checksum mismatch when copying the files or when running the migration?

@kpsherva there’s no checksum verification mechanism when copying the files. I had the checksum mismatch during the migration. I copied the files again, and everything worked fine.

I think we should verify the checksums when copying the files to prevent errors during migration.