Fix auto-declaration with local counters - #2
Open
xsedla1o wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix event auto-declaration when local counters are enabled through
sync_intervalorsync_limit.EventGroup.declare_event_id()previously iterated over the interval names inself.countersinstead of the interval counter dictionaries. Logging an unknown event with bothauto_declare_eventsand local counters enabled therefore raised aTypeError.The declaration now:
counter_lock, preventing races with logging and synchronization;This has gone unnoticed as configurations used a
sync-intervalkey with-instead of_, which disabled local counters silently.A regression test covers declaring, logging, and synchronizing a dynamic event across multiple intervals.