fix(pull): continue when optional size query is unavailable - #195
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Luskan passes its health check but the subsequent size query fails,
datatrail pullcurrently aborts before downloading. Treat service, connection, and timeout failures in that optional query as an unknown size so the normal confirmation prompt or--forcecan proceed. Authentication, certificate, and invalid-request errors retain their existing handling.Adds 25 regression cases covering query failures, confirmation and cancellation, forced downloads, and known-size behavior. The full non-CADC suite passes on Python 3.10 and 3.14 (288 tests on each), and all pre-commit hooks pass. The 9 credential-dependent CADC tests were excluded.
Fixes #98.