fix(scout): restore discrepancy detection and confirmed repairs - #197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datatrail scoutcan crash when scopes are omitted, miss Minoc discrepancies, and send site checksums to a misspelled endpoint. Site checksum responses also use absolute filenames, while the repair endpoint expects dataset-relative names; passing them through can report success without creating replicas.Use the returned scopes and each scope's site set, include the queried Minoc count, and render every reported storage site. Fetch checksums from the correct endpoint and normalize remote filenames to the backend's expected names with strict root and dataset boundaries. Repairs still require individual confirmation; invalid reports, failed queries, and malformed checksum payloads prevent the affected repair and produce a nonzero exit status. Independent confirmed repairs may continue after a failure.
Adds 45 regression cases, including Minoc recovery, omitted scopes, different site sets, CHIME/baseband-buffer comparisons, realistic absolute checksum paths, cancellation, and HTTP/transport/payload failures. The combined non-CADC suite passes on Python 3.10 and 3.14 (343 tests on each), and all pre-commit hooks pass. Nine tests requiring CADC credentials are excluded; no live archive repairs were performed.
Fixes #85.
Fixes #86.
Fixes #104.