Repository navigation
Call the shared CTTIR workflows - #3
Merged
Merged
Conversation
added 4 commits
August 21, 2026 20:33
Replaces 119 lines of copied YAML with three caller stubs. Behaviour changes that come with the shared versions: * R-CMD-check gains an oldrel-3 job, so the R version DESCRIPTION claims to support is actually built, and passes --as-cran. * test-coverage computes its gate with covr and an explicit exit rather than delegating to Codecov, with an absolute floor of 90% instead of target: auto plus a 1% threshold that permitted unlimited decay. * lint is new. hexmakR measured 0 house-linter findings on 2026-08-21, so it blocks from the start rather than shipping report-only. Pinned to the feature branch until CTTIR/.github#2 merges, then @main.
The reusable lint workflow checks out CTTIR/.github for its linter definitions and defaults that checkout to main, which does not yet carry config/lint-cttir.R. Pin both to the same branch until it merges.
I set blocking: true on the claim that hexmakR measured zero house-linter findings. That was wrong - hexmakR was never in the measured set, and I had conflated it with themakR, which is the package with zero. Measured properly, hexmakR has 15: 14 stop()/warning() calls that should be cli::cli_abort()/cli_warn(), and one multi-entry globalVariables(). Local and CI counts agree exactly.
Collaborator
Author
|
Correction: hexmakR has 15 house-linter findings, not 0. I opened this PR saying hexmakR measured zero and set Actual findings: 14 What the pilot established, which was its purpose:
Two design bugs it caught, both now fixed in CTTIR/.github#2:
|
CTTIR/.github#2 has merged, so the reusable workflows and the linter config are on main. config-ref is no longer needed - it defaults to main.
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pilot for the shared-workflow rollout (CTTIR/.github#2). hexmakR was chosen because it is green and measured 0 house-linter findings, so anything that goes red here is the shared workflow's fault rather than pre-existing debt.
119 lines of copied YAML → 3 caller stubs.
What comes with the shared versions:
oldrel-3job, so the R versionDESCRIPTIONclaims to support is actually built, and passes--as-cran.target: auto, threshold: 1%, which compares only to the base commit and permits unlimited decay in 1% steps.@feat/org-infrastructureso it can be validated before that PR merges. Merge CTTIR/.github#2 first, then change the three refs to@main— three one-word edits.If this goes green, the remaining rollout is file creation and whole-file replacement across the other repos, which is the only kind of scripted change CONTRIBUTING.md permits.