Repository navigation
Import %||% from rlang - #2
Merged
Merged
Conversation
molpathR uses %||% 8 times in R/parsers.R without defining or importing it, while DESCRIPTION declares R (>= 4.1.0). %||% entered base R in 4.4.0, so the package is broken on the R versions it claims to support. The CI matrix (release/devel/oldrel-1) never builds one of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%||%is used 8 times inR/parsers.R, neither defined locally nor imported, whileDESCRIPTIONdeclaresR (>= 4.1.0).%||%entered base R in 4.4.0. On R 4.1–4.3 — versions this package claims to support — those calls fail. The current CI matrix is release/devel/oldrel-1, so no job ever builds an R version where it fires.importFrom(rlang, "%||%")added to NAMESPACE and the roxygen block, kept consistent by hand (roxygen2 unavailable here; entries placed where roxygen2 sorts them)rlangis already inImports, so no dependency changeFollow-up: adding
oldrel-3to this repo's matrix would let CI catch the next one.