Skip to content

cardtile editor: no engineering words; empty picture one row; press feedback; thin scrollbars - #58

Merged
cverorg merged 2 commits into
mainfrom
kitt/card-editor-words
Sep 24, 2026
Merged

cverorg merged 2 commits into
mainfrom
kitt/card-editor-words

Conversation

@cverorg

@cverorg cverorg commented Sep 24, 2026

Copy link
Copy Markdown
Member

Owner's ruler for the sandbox, rules 3 (no engineering words) and 6 (empty is never blank; a press answers).

  • w2/banned-words.mjs + w2/words.test.mjs: the banned list (sandbox, practice mode, preview-as-verb, srcdoc, iframe, parameters/raw/params, render, deploy, publish, "markdown mode") with per-locale patterns, scanned across every catalogue the editor uses in nine locales; a control plants words and proves the scan fires. First run: 92 hits, all fixed. Banner is now "You're trying Card — nothing is saved until you make it yours." / 「你正在試玩 Card。按下「把這張變成真的」之前,什麼都不會儲存。」 (the zh names the real button; 「——」 is banned in zh by an existing test). "Raw parameters" is gone from the w2 sheets (the Markdown view already shows the whole file); the old w/ editor's block reads "Advanced".
  • Empty picture tile: one grid row tall, same 18px radius and dashed outline as the empty link, a picture glyph beside the label; edit-only CSS emitted only under ctx.editIndex, so live cards never carry it. tile-geometry rule 2 now says an empty state may differ in height when the filled height comes from the picture; a test pins the row layout.
  • Press transform on every shell button (audited by a test over index.html's button classes) and on the in-card add button and drawer chip.
  • Thin translucent scrollbars on the shell's scrolling panes and the board document.

Verified on the preview Worker: tile-geometry ruler green on a real card; first-link ruler green (5 taps, link on the card at 2.3s); WebKit screenshots. Tests 261/261.

…s × every catalogue; 92 hits fixed — banner, Markdown label, 'Advanced' instead of raw parameters, the frame's accessible name); empty picture tile is one row with a glyph; press transforms on every shell button; thin scrollbars on the shell panes

Owner's six-rule ruler, rules 3 and 6. Tests 261/261.
…uared every grid tile inside the editor; live cards are 18px); the geometry ruler now measures grid tiles too
@cverorg
cverorg merged commit 74dc721 into main Sep 24, 2026
2 checks passed
@cverorg
cverorg deleted the kitt/card-editor-words branch September 24, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant