cardtile editor: no engineering words; empty picture one row; press feedback; thin scrollbars - #58
Merged
Merged
Conversation
…s × every catalogue; 92 hits fixed — banner, Markdown label, 'Advanced' instead of raw parameters, the frame's accessible name); empty picture tile is one row with a glyph; press transforms on every shell button; thin scrollbars on the shell panes Owner's six-rule ruler, rules 3 and 6. Tests 261/261.
…uared every grid tile inside the editor; live cards are 18px); the geometry ruler now measures grid tiles too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner's ruler for the sandbox, rules 3 (no engineering words) and 6 (empty is never blank; a press answers).
w2/banned-words.mjs+w2/words.test.mjs: the banned list (sandbox, practice mode, preview-as-verb, srcdoc, iframe, parameters/raw/params, render, deploy, publish, "markdown mode") with per-locale patterns, scanned across every catalogue the editor uses in nine locales; a control plants words and proves the scan fires. First run: 92 hits, all fixed. Banner is now "You're trying Card — nothing is saved until you make it yours." / 「你正在試玩 Card。按下「把這張變成真的」之前,什麼都不會儲存。」 (the zh names the real button; 「——」 is banned in zh by an existing test). "Raw parameters" is gone from the w2 sheets (the Markdown view already shows the whole file); the old w/ editor's block reads "Advanced".ctx.editIndex, so live cards never carry it. tile-geometry rule 2 now says an empty state may differ in height when the filled height comes from the picture; a test pins the row layout.Verified on the preview Worker: tile-geometry ruler green on a real card; first-link ruler green (5 taps, link on the card at 2.3s); WebKit screenshots. Tests 261/261.