cardtile editor: cancelling a just-added tile discards it - #62
Merged
Merged
Conversation
…dded discards it — the card returns to the exact markdown before the pick; Done keeps; existing tiles unchanged. Tests 276/276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured on production: add a tile → its sheet opens → ✕ without filling anything → the empty tile stayed (board: 'Video'; card: a dashed placeholder), and the person had to find and delete it. Now ✕/Escape/scrim on a just-added, never-saved tile restores the pre-add markdown byte for byte (undo history truncated to before the add); Done keeps it; an existing tile's ✕ is unchanged. Pure helper newTileCancelTarget + 3 bundle-level tests (add→✕ identical; add→Done present and a later ✕ keeps; existing ✕ keeps). Verified on the preview Worker in WebKit (before 2 → cancel 2 → done 3; draft has no video, has the kept text). Tests 276/276.