test: add Pest v1 security test infrastructure - #42
Draft
somethingwithproof wants to merge 5 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Pest v1-based test scaffolding to the hmib plugin repo, focusing on security-oriented source scans and PHP 7.4 compatibility checks.
Changes:
- Add Composer dev dependency for Pest v1 and wire up test bootstrap loading.
- Introduce a Pest bootstrap with Cacti framework stub functions/constants for isolated plugin testing.
- Add security/compatibility source-scan tests for setup.php structure, prepared-statement helper usage, and PHP 7.4 compatibility.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
composer.json |
Adds Pest v1 as a dev dependency and autoloads the test bootstrap. |
tests/Pest.php |
Pest configuration entrypoint that loads the bootstrap. |
tests/bootstrap.php |
Provides Cacti framework stubs/constants for running tests without full Cacti. |
tests/Security/SetupStructureTest.php |
Verifies setup.php exports expected plugin hook functions and version keys. |
tests/Security/PreparedStatementConsistencyTest.php |
Scans plugin source for raw db_* calls vs _prepared helpers. |
tests/Security/Php74CompatibilityTest.php |
Scans plugin source for PHP 8+ syntax/functions to preserve PHP 7.4 compatibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
somethingwithproof
marked this pull request as draft
April 11, 2026 00:09
Member
Author
|
Converted to draft to serialize the stack in this repo. Blocked by #40; will un-draft after that merges to avoid cross-PR merge conflicts. |
Add source-scan tests verifying security patterns (prepared statements, output escaping, auth guards, PHP 7.4 compatibility) remain in place across refactors. Tests run with Pest v1 (PHP 7.3+) and stub the Cacti framework so plugins can be tested in isolation. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…dabot - Throw RuntimeException when realpath/file_get_contents fails (previously silent continue hid unscanned files) - Fix Dependabot ecosystem from npm to composer - Remove committed .omc session artifacts, add .omc/ to .gitignore Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
test/add-security-test-infrastructure
branch
from
July 14, 2026 10:47
43eb779 to
9e38bce
Compare
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
composer install && vendor/bin/pestpasses