fix(security): defense-in-depth hardening for plugin_maint - #50
Draft
somethingwithproof wants to merge 7 commits into
Draft
fix(security): defense-in-depth hardening for plugin_maint#50somethingwithproof wants to merge 7 commits into
somethingwithproof wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Defense-in-depth hardening for the maint Cacti plugin by reducing XSS risk in UI-generated forms and adding automated dependency update configuration.
Changes:
- Escapes
page/idrequest variables before rendering them into hidden form inputs inmaint.php. - Adds a Dependabot configuration to check for npm and GitHub Actions updates weekly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| maint.php | Escapes request vars when output in hidden inputs to reduce XSS risk. |
| .github/dependabot.yml | Introduces Dependabot update schedules for npm and GitHub Actions. |
somethingwithproof
marked this pull request as draft
April 11, 2026 00:09
Member
Author
|
Converted to draft to serialize the stack in this repo. Blocked by #49; will un-draft after that merges to avoid cross-PR merge conflicts. |
Automated fixes: - XSS: escape request variables in HTML value attributes - SQLi: convert string-concat queries to prepared statements - Deserialization: add allowed_classes=>false - Temp files: replace rand() with tempnam() Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
- Change Dependabot ecosystem from npm to composer (PHP-only repo) - Remove PHP from CodeQL paths-ignore so security PRs get analysis - Remove committed .omc session artifacts, add .omc/ to .gitignore Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/defense-in-depth
branch
from
July 14, 2026 10:47
952b91c to
12044ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defense-in-depth hardening addressing 24 security audit findings.
html_escape_request_var()allowed_classes => falsetounserialize()All changes PHP 7.0+ compatible.
Test plan