Skip to content

test: add Pest v1 security test infrastructure - #52

Draft
somethingwithproof wants to merge 13 commits into
Cacti:developfrom
somethingwithproof:test/add-security-test-infrastructure
Draft

test: add Pest v1 security test infrastructure#52
somethingwithproof wants to merge 13 commits into
Cacti:developfrom
somethingwithproof:test/add-security-test-infrastructure

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Summary

  • Add Pest v1 test scaffold with Cacti framework stubs
  • Source-scan tests for prepared statement consistency
  • PHP 7.4 compatibility verification tests
  • Plugin setup.php structure validation

Test plan

  • composer install && vendor/bin/pest passes
  • Tests verify security patterns match hardening PRs

Copilot AI review requested due to automatic review settings April 9, 2026 06:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Pest v1 test scaffold for the maint plugin with security/compatibility source-scan tests and supporting Composer/Dependabot configuration.

Changes:

  • Introduces Pest bootstrap/config and new security-focused tests under tests/Security/.
  • Adds a composer.json with Pest as a dev dependency and test bootstrap autoloading.
  • Adds a Dependabot configuration file.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
tests/Security/SetupStructureTest.php Scans setup.php for expected plugin entry points/metadata.
tests/Security/PreparedStatementConsistencyTest.php Scans key plugin files for unprepared db_* helper usage.
tests/Security/Php74CompatibilityTest.php Scans for PHP 8+ syntax/functions to preserve PHP 7.4 compatibility.
tests/Pest.php Loads the test bootstrap for Pest runs.
tests/bootstrap.php Provides Cacti/framework stubs so tests can run in isolation.
composer.json Adds Pest v1 as a dev dependency and autoloads the bootstrap.
.github/dependabot.yml Configures automated dependency update checks (currently for npm + GitHub Actions).

Comment thread tests/Security/SetupStructureTest.php Outdated
Comment thread tests/Security/SetupStructureTest.php Outdated
Comment thread tests/Security/PreparedStatementConsistencyTest.php Outdated
Comment thread tests/Security/PreparedStatementConsistencyTest.php Outdated
Comment thread tests/Security/Php74CompatibilityTest.php Outdated
Comment thread composer.json
Comment thread .github/dependabot.yml Outdated
Comment thread .github/dependabot.yml Outdated
@somethingwithproof
somethingwithproof marked this pull request as draft April 11, 2026 00:09
@somethingwithproof

Copy link
Copy Markdown
Member Author

Converted to draft to serialize the stack in this repo. Blocked by #49; will un-draft after that merges to avoid cross-PR merge conflicts.

Add source-scan tests verifying security patterns (prepared statements,
output escaping, auth guards, PHP 7.4 compatibility) remain in place
across refactors. Tests run with Pest v1 (PHP 7.3+) and stub the Cacti
framework so plugins can be tested in isolation.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…dabot

- Throw RuntimeException when realpath/file_get_contents fails
  (previously silent continue hid unscanned files)
- Fix Dependabot ecosystem from npm to composer
- Remove committed .omc session artifacts, add .omc/ to .gitignore

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@somethingwithproof
somethingwithproof force-pushed the test/add-security-test-infrastructure branch from 499906a to 5917961 Compare July 14, 2026 10:46
TheWitness
TheWitness previously approved these changes Jul 15, 2026
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…est script

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants