fix(security): defense-in-depth hardening for plugin_webseer - #66
Draft
somethingwithproof wants to merge 7 commits into
Draft
fix(security): defense-in-depth hardening for plugin_webseer#66somethingwithproof wants to merge 7 commits into
somethingwithproof wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to harden plugin_webseer against deserialization attacks by restricting classes during unserialize() of remote data.
Changes:
- Updates server list refresh to add an
allowed_classesrestriction during deserialization. - Updates URL list refresh to add an
allowed_classesrestriction during deserialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
somethingwithproof
marked this pull request as draft
April 11, 2026 00:10
Member
Author
|
Converted to draft to serialize the stack in this repo. Blocked by #65; will un-draft after that merges to avoid cross-PR merge conflicts. |
Automated fixes: - XSS: escape request variables in HTML value attributes - SQLi: convert string-concat queries to prepared statements - Deserialization: add allowed_classes=>false - Temp files: replace rand() with tempnam() Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Replace .click(fn) with .on('click', fn), .change(fn) with
.on('change', fn), .submit(fn) with .on('submit', fn), .unbind()
with .off(), and .resize(fn) with .on('resize', fn).
These shorthands were deprecated in jQuery 3.3 and will be removed
in jQuery 4.0. Cacti core ships jQuery 3.x on develop.
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
The options array was mistakenly passed as the second arg to base64_decode(), where it is interpreted as the boolean $strict parameter. The allowed_classes restriction is never applied. Move the options array to the second arg of unserialize(). Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
- Use strict mode for base64_decode - Check decoded result before unserialize - Suppress unserialize warnings with @ and check is_array - Log and break on any failure Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
- Change Dependabot ecosystem from npm to composer (PHP-only repo) - Remove PHP from CodeQL paths-ignore so security PRs get analysis - Remove committed .omc session artifacts, add .omc/ to .gitignore Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/defense-in-depth
branch
from
July 14, 2026 10:47
a48c39d to
75252de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defense-in-depth hardening addressing 26 security audit findings.
html_escape_request_var()allowed_classes => falsetounserialize()All changes PHP 7.0+ compatible.
Test plan