Repository navigation
feat: /sdd-close for the close-out and the clean-up after the merge - #55
Merged
Merged
Conversation
…and findings `sdd-pr clean [<branch>] [--pr N] [--dry-run]` runs after the merge from any checkout, a detached one included. It removes the branch's worktree (the main checkout steps onto the base instead; one the command or the shell runs in is left, with the commands), deletes the local branch only when it holds no commit the merged pull request lacks (with forge: none, once in the base), then its findings file, delivery notes and pass note. Every check runs before any change: the pull request merged, no line in the findings file that would be lost, no uncommitted work, no locked worktree, not the base or the default branch, and, when unnamed, a branch that has a findings file or notes. A worktree deleted by hand is pruned. It never touches the pull request or the remote branch. `status` points a ready draft and a merged pull request at /sdd-close and names the lines that wait for /sdd-triage --backlog instead of putting the harvest first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ns up after the merge The close-out loaded all of sdd-deliver (1616 words) to use about 230 of them; in multi-PR sessions more than half the sdd-deliver invocations were close-outs. sdd-close (867 words) does the close-out in the pull request, asks once whether to carry the lines that do not block to docs/backlog.md there, and, run again after the maintainer merges on the forge, cleans up with sdd-pr clean. It never merges or closes a pull request. sdd-deliver ends at the maintainer's review (1393 words); --close-out points to sdd-close for this release. The router, sdd-trace, sdd-triage, the hooks, the Cursor rule, the references, the process templates and the docs name /sdd-close; /sdd-triage --backlog becomes an occasional run. Word budgets: sdd-close new at 867, sdd-deliver 1616 -> 1393, router 584 -> 606, review.md 2556 -> 2671, ai-workflow.md 1151 -> 1162. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sdd-close. It takes the close-out out of/sdd-deliver:REQshipped, acceptance ticks, the changelog line,generate, the full gate, the PR body, a draft marked ready;outsidelines todocs/backlog.mdin the pull request itself (recommended), or leave them for the next/sdd-triage --backlog.sdd-pr clean [<branch>] [--pr N] [--dry-run]. It removes a merged branch's worktree, the local branch and its findings file and delivery notes./sdd-deliverends at the maintainer's review.--close-outpoints to/sdd-closefor this release./sdd-triage --backlogbecomes an occasional run./sdd-close: the router,sdd-trace,sdd-triage, the session-start hook, the edit reminder, the Cursor rule, the references, the process templates, the docs, andupgrading.md(0.13.x to 0.14.0).Why
sdd-deliver(1,616 words) to use about 230 of them. In the multi-PR sessions sampled, 31 of 53sdd-deliverinvocations were close-outs. A close-out now loads 867 words, and a delivery 1,393.Word budgets
sdd-closesdd-deliverreview.mdai-workflow.mdReview
Two reviews ran before this PR, and their findings are fixed:
forge: none, the skill picked the wrong steps.clean:develop.--proverrode a named branch.Test plan
python3 -m unittest discover -s tools/tests: 574 pass, 15 of them in the newTestClean. A mutation check shows each of the seven new guards is pinned by a test../scripts/validate.sh,python3 tools/sdd-check.py selftest,claude plugin validate .forge: none, seven cases:.env;--rootelsewhere with the shell inside the worktree;developwith nothing delivered;/sdd-closebefore the merge (the carry question,resolve, ready), then after the merge, including after a squash merge with GitHub deleting the head branch.🤖 Generated with Claude Code