Repository navigation
docs: close 2.2.0: the changelog dated, the gate's pass recorded, a declared response kept as declared - #64
Merged
Conversation
…eclared response kept as declared The 2.2.0 section of CHANGELOG.md is dated 2026-10-18, which the release workflow reads as the release notes, and AnalyzerReleases.Shipped.md gets its empty "Release 2.2.0" section, since the consolidation release ships no rule. Record 0108 and its index row say the gate passed on release/2.2.0 on 2026-10-18, by #62 (declarations, exclusions and rows for the 17 refusals) and #63 (the fix for F4, which C21's regenerated rows raised and the code-analyst confirmed). The AspNetCore README says what the code-analyst's A4 found undocumented and the maintainer decided on 2026-10-18 to keep: a response an endpoint declares itself at a fault status, with Produces(404) or [ProducesResponseType(404)], is kept as declared, and the document adds no problem schema there, though the wire still answers a problem (FaultResponsesOperationTransformer: "A response the operation already has is kept"). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The gate passes on release/2.2.0 since #62 and #63, but the changelog's 2.2.0 section is still "Unreleased", record 0108 still describes the gate as refusing, and the code-analyst's A4 item (a response an endpoint declares at a fault status gets no problem schema in the document) was intended in the code and said nowhere a consumer reads.
Change
CHANGELOG.md: the 2.2.0 section dated 2026-10-18 (the release workflow's notes).src/CodoMetis.TypeKit.Analyzers/AnalyzerReleases.Shipped.md: an empty## Release 2.2.0, whichChangelogTestsrequires of a dated version; the consolidation release ships no rule.design/adr/0108…anddesign/adr/README.md: the gate passed on release/2.2.0 on 2026-10-18, by build: answer the gate's refusals with rows, declarations and exclusions; the gate passes #62 and fix: a nullable value object that is a component keeps its null as a get-only property, a field and an oblivious one #63.src/CodoMetis.TypeKit.AspNetCore/README.md, "A Result as a response": a response you declare yourself at one of the mapped statuses is kept as declared; the document adds no problem schema there, though the wire still answers a problem. The maintainer's A4 decision of 2026-10-18.No code changes. The README's compiled blocks are untouched, and no claim in
claims.jsonquotes the changed paragraph.Tests
CodoMetis.TypeKit.Conventions.Tests: 1,501 passed (ChangelogTests,DesignRecordTests,DocumentationLinkTests,ReadmeSampleTestsamong them).build-verdict build src/CodoMetis.TypeKit.Analyzers: OK.docs-query check: 0 problems.🤖 Generated with Claude Code