Remove redundant model registration - #47
Merged
CaitlynMainer merged 2 commits intoAug 11, 2026
Merged
Conversation
- Move floppy color handler to live with the other items/blocks - Remove ModelInitialization.registerModel and all callers of it (it's just an empty method). - Remove NullModel — we already register a blockstate JSON using air.
SquidDev
marked this pull request as ready for review
August 11, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelInitialization.registerModeland all callers of it (it's just an empty method).NullModel— we already register a blockstate JSON using air.There's some more cleanup to do here, just trying to avoid creating another massive PR :D. We don't need custom model implementations for drones or cables, and we could definitely move some of the the rack and net splitter model to JSON). The less custom model code we have, the easier updating to 26.2 will be.