Skip to content

fix(ci): ignore Make scheduling barriers in target checks #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaliLuke merged 1 commit into from
Oct 21, 2026
Merged

fix(ci): ignore Make scheduling barriers in target checks #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions scripts/lint_ci_contract.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ target_prerequisites() {
awk -v target="$target" '
$1 == target ":" {
for (i = 2; i <= NF; i++) {
printf "%s%s", (i == 2 ? "" : " "), $i
# GNU Make adds .WAIT barriers for .NOTPARALLEL prerequisites.
# They control scheduling; they are not additional build targets.
if ($i != ".WAIT") {
printf "%s%s", separator, $i
separator = " "
}
}
print ""
found = 1
Expand All @@ -40,19 +45,35 @@ target_prerequisites() {
exit 1
}
}
' "$MAKE_DATABASE"
' "${2:-$MAKE_DATABASE}"
}

assert_prerequisites() {
local target="$1"
local expected="$2"
local actual
actual="$(target_prerequisites "$target")" || fail "missing Make target $target"
actual="$(target_prerequisites "$target" "${3:-$MAKE_DATABASE}")" || fail "missing Make target $target"
if [[ "$actual" != "$expected" ]]; then
fail "Make target $target prerequisites are [$actual], want [$expected]"
fi
}

PREREQUISITE_FIXTURE="$TMP_BASE/prerequisites.db"
cat >"$PREREQUISITE_FIXTURE" <<'EOF'
plain: first second
serialized: .WAIT first .WAIT .WAIT second .WAIT
barriers-only: .WAIT .WAIT
EOF
assert_prerequisites plain "first second" "$PREREQUISITE_FIXTURE"
assert_prerequisites serialized "first second" "$PREREQUISITE_FIXTURE"
assert_prerequisites barriers-only "" "$PREREQUISITE_FIXTURE"
if (assert_prerequisites serialized "first second third" "$PREREQUISITE_FIXTURE") >/dev/null 2>&1; then
fail "prerequisite parser ignored a missing build target"
fi
if target_prerequisites missing "$PREREQUISITE_FIXTURE" >/dev/null; then
fail "prerequisite parser accepted a missing Make target"
fi

assert_prerequisites all "lint test integration-test"
assert_prerequisites ci "depend all coverage-ratchet"
assert_prerequisites ci-local "all coverage-ratchet test-race openapi-contract generated-code-quality test-testdata-compile value-contract-conformance"
Expand Down
Loading