Repository navigation
test(pool): prevent failed-stop eviction regression deadlock - #948
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (4 skipped: 4 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The description clearly explains the regression-test deadlock, the corrected callback ordering, the added TLA model, and the validation performed. |
| Title check | |
The title concisely and accurately identifies the pool regression-test change and its purpose: preventing a failed-stop eviction deadlock. |
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I’m a rabbit; I watched the stop,
The tracked job stayed put in place.
Once released, the checks ran on,
Two models traced the callback race.
I thump my feet for tidy states!
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
The daily release publisher is blocked by main CI run 38646089002, where
TestEvictionStopsJobRestoredByFailedStopwaits indefinitely inWorker.stop.stopJobpublishes a stream event before processing the stop directly, so the event loop can acquire the test's gated callback first. The test then joins that loop before releasing its callback gate.Join the worker runtime before publishing the controlled stop, leaving the direct caller to own the callback. Preserve the failed-stop/eviction overlap and verify that the job stays tracked while blocked, the handler failure reaches the caller, and eviction retries Stop and clears the job. Add deferred gate release and bounded completion waits. Production behavior is unchanged.
The adjacent TLA model reproduces the original circular wait and checks the corrected ordering.
Validation: 100 regression repetitions; related stop/rebalance tests repeated 10 times with the race detector; complete
pulse/poolsuite; pinned package lint; repository-wide lint and full root-module unit suite through the commit/push hooks. Independent agent review reported no findings. GitHub CI is running.