Repository navigation
feat(webhooks): sign webhook deliveries with managed rotation keys - #1472
Open
lienhoatienphung-svg wants to merge 1 commit into
Open
lienhoatienphung-svg wants to merge 1 commit into
lienhoatienphung-svg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1234
Summary
Wires
WebhookSignerintodispatchWebhook(src/webhooks/webhook.dispatcher.ts) and the admin key rotation routes (src/routes/admin/webhookKeys.ts) via a shared default signer instance (getDefaultWebhookSigner). Outbound webhook deliveries now includeX-Callora-Signature-KidalongsideX-Callora-SignatureandX-Callora-Timestamp, andWebhookSigner.verifyPayloadverifies signatures during key rotation grace windows while rejecting expired retired keys.Acceptance Criteria Mapping
X-Callora-Signature,X-Callora-Timestamp, andX-Callora-Signature-Kid: Verified insrc/webhooks/webhook.dispatcher.test.ts.kidused on subsequent deliveries: Admin routes sharegetDefaultWebhookSigner()withdispatchWebhook.verifyPayloadaccepts signatures from both active and grace-period keys and rejects expired retired keys: Implemented and verified insrc/services/webhookSigner.test.ts.WEBHOOK_SIGNATURE_VERIFICATION.md.Validation
npx jest src/services/webhookSigner.test.ts src/webhooks/webhook.dispatcher.test.ts --no-cache(all 76 tests pass).Payout Wallet (Base Mainnet USDC / EVM):
0x3806cd592a508d1992Ed007C2F53de251C2E7452