Repository navigation
feat(webhooks): generate signing secret automatically on registration (#1211) - #1484
Closed
lienhoatienphung-svg wants to merge 1 commit into
Closed
lienhoatienphung-svg wants to merge 1 commit into
lienhoatienphung-svg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatically generates a 32-byte (64-hex-char) signing secret when
POST /api/webhooksis called without asecret, returns the secret once in the201 Createdresponse body, rejects caller-supplied secrets shorter than 32 characters with400 Bad Request, and ensures all subsequent webhook deliveries carryX-Callora-Signature.Closes #1211
Key Changes
src/routes/webhooks.ts):secretvalues shorter than 32 characters with400 Bad Request(INVALID_WEBHOOK_SECRET).generateWebhookSecret()(32 random bytes = 64 hex chars) whensecretis omitted, persists it inWebhookStore, and returnssecretonce in the201response body while keepingGET /api/webhooks/:developerIdfree of secret fields.src/webhooks/webhook.dispatcher.ts):resolveWebhookSigningSecret(config)to resolveconfig.secret_current ?? config.secretso subscriptions registered withsecret_currentalways sign outbound payloads withX-Callora-Signature.docs/webhooks.md,WEBHOOK_SIGNATURE_VERIFICATION.md):201 Created.Verification
npx jest src/routes/webhooks.test.ts src/webhooks/webhook.dispatcher.test.ts(all tests passed).Payout Wallet (Base Mainnet USDC)
0x3806cd592a508d1992Ed007C2F53de251C2E7452