Skip to content

Announce fee configuration and deposit changes #1189

Closed
Closed
Announce fee configuration and deposit changes#1189
Labels
Stellar WaveStellar Wave Program issue

Description

@greatest0fallt1me
greatest0fallt1me
opened on Sep 27, 2026

Summary

Only withdraw emits an event (fee_withdrawn, without version topic or admin). init, set_fee and deposit are silent.

Why this matters

Fee-rate changes directly affect revenue splits; without events they cannot be audited or alerted on.

Scope

Emit fee_init, fee_set(old, new) and fee_deposited(caller, amount, total) events with a version topic, and add the admin to fee_withdrawn topics.

Relevant code in CalloraOrg/Callora-Contracts:

  • contracts/fee/src/lib.rs

Priority

Low

Acceptance criteria

  • Each state-changing function emits one event
  • fee_set includes old and new bps
  • Event topics follow the workspace (name, v1, subject) shape
  • Deposits of zero or negative amounts emit no event

Validation

cargo test -p callora-fee events

Non-goals

  • Typo-only, formatting-only, or cosmetic changes.
  • Unrelated refactors, dependency upgrades, or broad rewrites.
  • Removing safeguards or weakening validation to make tests pass.

Contributor application

Before coding, describe the affected modules, proposed state/invariant changes, test strategy, compatibility considerations, and an estimate. Wait for assignment before starting implementation.

PR requirements

Use a feature branch and include Closes #<issue-number>. Address every criterion, map criteria to code and tests, explain security and failure-mode handling, and ensure CI passes.

Quality review

A maintainer will assess correctness, completeness, test depth, compatibility, observability, and adverse-case handling. A substantive implementation is required; merge or CI status alone does not guarantee reward eligibility.

Generated by Claude Code

Activity

  1. greatest0fallt1me
    changed the title [-]Keep leaderboard rank pages deterministic[/-] [+]Add focused test coverage for contracts/rescue/src/lib.rs[/+] on Sep 27, 2026
  2. greatest0fallt1me
    changed the title [-]Add focused test coverage for contracts/rescue/src/lib.rs[/-] [+]Announce fee configuration and deposit changes[/+] on Sep 27, 2026
  3. greatest0fallt1me
    added
    Stellar WaveStellar Wave Program issue
    on Sep 27, 2026

  4. devgbmuyiwa commented on Sep 27, 2026

    @devgbmuyiwa
    devgbmuyiwa
    on Sep 27, 2026 – with Drips Wave

    @devgbmuyiwa has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    hello can i work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @devgbmuyiwa to this issue.

  5. premiuslol commented on Sep 30, 2026

    @premiuslol
    premiuslol
    on Sep 30, 2026 – with Drips Wave

    @premiuslol has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I checked the current issue #1189, 'Announce fee configuration and deposit changes'. The affected paths include contracts/fee/src/lib.rs. I would reproduce the failing path, fix the underlying source/setup behavior rather than weaken the assertions, and add focused regression coverage. I would run the relevant repository tests plus lint/typecheck/build checks that apply before submitting. I can complete this once assigned.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @premiuslol to this issue.

  6. Ayfataan commented on Sep 30, 2026

    @Ayfataan
    Ayfataan
    on Sep 30, 2026 – with Drips Wave
    Contributor

    @Ayfataan has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I’d like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ayfataan to this issue.

  7. Rodrigoue9 commented on Oct 3, 2026

    @Rodrigoue9
    Rodrigoue9
    on Oct 3, 2026

    Hi @maintainers! I'd like to work on this issue. Here is my proposed technical approach:

    Proposed Technical Approach:

    1. Contract Logic Implementation: Implement the required Soroban smart contract logic in Rust, ensuring strict validation, authorization checks (require_auth), and gas optimization.
    2. Storage Layout & State Management: Maintain safe data key patterns, TTL management, and prevent state inconsistency or unauthorized state mutations.
    3. Events & Error Encoding: Emit strongly typed contract events and return descriptive custom errors for all failure modes.
    4. Comprehensive Test Vectors: Implement Rust unit and integration tests using soroban-sdk::Env verifying both success and failure execution paths.

    Key Files:

    • contracts/**/src/lib.rs (contract entrypoints and interface implementations)
    • contracts/**/src/types.rs or storage.rs (types, data keys, and state)
    • contracts/**/src/test.rs (unit tests and integration vectors)

    Verification & Testing:

    • Run cargo test across all contract crates verifying 100% pass rate.
    • Run cargo clippy --all-targets -- -D warnings and cargo fmt --check.
    • Verify Soroban WASM build: soroban contract build.

    Relevant Track Record:

    I have successfully implemented and merged multiple production PRs across the Stellar ecosystem and Web3 open-source projects (e.g., Bitcoindefi/OpenAO #218, cybermax4200/stellar-did-credit #898 & #900, and FindMalek/sonaraem #416).

    Please feel free to assign this issue to me so I can proceed with the implementation. Thank you!

  8. shobhamerabacha-star commented on Oct 7, 2026

    @shobhamerabacha-star
    shobhamerabacha-star
    on Oct 7, 2026

    Hello maintainers,

    I am interested in taking up Announce fee configuration and deposit changes.

    Implementation approach:

    1. Audit storage layout and state invariants ensuring strict auth guards.
    2. Implement deterministic state transitions with safe checked arithmetic.
    3. Add hermetic unit and regression tests covering authorized, unauthorized, and boundary edge cases.
    4. Profile instruction and CPU/gas limits under Soroban host environment.

    Could you please assign this issue to me? Looking forward to delivering a clean PR.

  9. Bkizzy16 commented on Oct 15, 2026

    @Bkizzy16
    Bkizzy16
    on Oct 15, 2026 – with Drips Wave

    @Bkizzy16 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Please kindly assign me this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Bkizzy16 to this issue.

  10. lienhoatienphung-svg commented on Oct 16, 2026

    @lienhoatienphung-svg
    lienhoatienphung-svg
    on Oct 16, 2026

    Hi! I have implemented and verified this in #1377 with full unit test coverage and rustfmt compliance.

  11. lienhoatienphung-svg
    added a commit that references this issue on Oct 16, 2026

    feat(fee): emit versioned events for init, set_fee, deposit, and with…

    fff1b50

  12. comrade10-coder commented on Oct 16, 2026

    @comrade10-coder
    comrade10-coder
    on Oct 16, 2026 – with Drips Wave

    @comrade10-coder has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer! I’m interested in contributing to this task and can work toward delivering a clean solution on time.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @comrade10-coder to this issue.

  13. Ezekiel146 commented on Oct 16, 2026

    @Ezekiel146
    Ezekiel146
    on Oct 16, 2026 – with Drips Wave

    @Ezekiel146 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer, I am interested in working on this issue and would love it it is being assigned to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ezekiel146 to this issue.

  14. Mrbleatz commented on Oct 16, 2026

    @Mrbleatz
    Mrbleatz
    on Oct 16, 2026 – with Drips Wave

    @Mrbleatz has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hey I'm a Maintaner I Understand This Just Give Me a Chance even though I'm new here

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Mrbleatz to this issue.

  15. greatest0fallt1me
    closed this as completedon Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Stellar WaveStellar Wave Program issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions