Skip to content

Transfer registry admin via nominate-and-accept #1207

Closed
Closed
Transfer registry admin via nominate-and-accept#1207
Labels
Stellar WaveStellar Wave Program issue

Description

@greatest0fallt1me
greatest0fallt1me
opened on Sep 27, 2026

Summary

Registry sets StorageKey::Admin at init and has no admin rotation entrypoints.

Why this matters

Admin key rotation is impossible without redeploying and re-registering every offering.

Scope

Add set_admin, accept_admin, cancel_admin_transfer, with events and auth snapshot coverage.

Relevant code in CalloraOrg/Callora-Contracts:

  • contracts/registry/src/lib.rs
  • contracts/registry/tests/auth_snap.rs

Priority

Low

Acceptance criteria

  • Nominee can accept, others cannot
  • Cancel works
  • Snapshots updated
  • Admin rotation does not reset the registration cooldown

Validation

cargo test -p callora-registry --test auth_snap

Non-goals

  • Typo-only, formatting-only, or cosmetic changes.
  • Unrelated refactors, dependency upgrades, or broad rewrites.
  • Removing safeguards or weakening validation to make tests pass.

Contributor application

Before coding, describe the affected modules, proposed state/invariant changes, test strategy, compatibility considerations, and an estimate. Wait for assignment before starting implementation.

PR requirements

Use a feature branch and include Closes #<issue-number>. Address every criterion, map criteria to code and tests, explain security and failure-mode handling, and ensure CI passes.

Quality review

A maintainer will assess correctness, completeness, test depth, compatibility, observability, and adverse-case handling. A substantive implementation is required; merge or CI status alone does not guarantee reward eligibility.

Generated by Claude Code

Activity

  1. greatest0fallt1me
    changed the title [-]Keep leaderboard rank pages deterministic[/-] [+]Add focused test coverage for contracts/revenue_pool/tests/proptest_admin.rs[/+] on Sep 27, 2026
  2. greatest0fallt1me
    changed the title [-]Add focused test coverage for contracts/revenue_pool/tests/proptest_admin.rs[/-] [+]Transfer registry admin via nominate-and-accept[/+] on Sep 27, 2026
  3. greatest0fallt1me
    added
    Stellar WaveStellar Wave Program issue
    on Sep 27, 2026

  4. Uhiara commented on Sep 27, 2026

    @Uhiara
    Uhiara
    on Sep 27, 2026 – with Drips Wave

    @Uhiara has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    In 1 hour time, I will be done with this. Let me handle it

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Uhiara to this issue.

  5. Obetaebube3 commented on Sep 30, 2026

    @Obetaebube3
    Obetaebube3
    on Sep 30, 2026 – with Drips Wave

    @Obetaebube3 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    give me this job and rest assured of greatness

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Obetaebube3 to this issue.

  6. boluxx123 commented on Sep 30, 2026

    @boluxx123
    boluxx123
    on Sep 30, 2026 – with Drips Wave
    Contributor

    @boluxx123 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hi Dev, I would like to work on this issue and make PR immediately today
    Kindly assign. I'm active and ready to work.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @boluxx123 to this issue.

  7. Rodrigoue9 commented on Oct 3, 2026

    @Rodrigoue9
    Rodrigoue9
    on Oct 3, 2026

    Hi @maintainers! I'd like to work on this issue. Here is my proposed technical approach:

    Proposed Technical Approach:

    1. Contract Logic Implementation: Implement the required Soroban smart contract logic in Rust, ensuring strict validation, authorization checks (require_auth), and gas optimization.
    2. Storage Layout & State Management: Maintain safe data key patterns, TTL management, and prevent state inconsistency or unauthorized state mutations.
    3. Events & Error Encoding: Emit strongly typed contract events and return descriptive custom errors for all failure modes.
    4. Comprehensive Test Vectors: Implement Rust unit and integration tests using soroban-sdk::Env verifying both success and failure execution paths.

    Key Files:

    • contracts/**/src/lib.rs (contract entrypoints and interface implementations)
    • contracts/**/src/types.rs or storage.rs (types, data keys, and state)
    • contracts/**/src/test.rs (unit tests and integration vectors)

    Verification & Testing:

    • Run cargo test across all contract crates verifying 100% pass rate.
    • Run cargo clippy --all-targets -- -D warnings and cargo fmt --check.
    • Verify Soroban WASM build: soroban contract build.

    Relevant Track Record:

    I have successfully implemented and merged multiple production PRs across the Stellar ecosystem and Web3 open-source projects (e.g., Bitcoindefi/OpenAO #218, cybermax4200/stellar-did-credit #898 & #900, and FindMalek/sonaraem #416).

    Please feel free to assign this issue to me so I can proceed with the implementation. Thank you!

  8. shobhamerabacha-star commented on Oct 7, 2026

    @shobhamerabacha-star
    shobhamerabacha-star
    on Oct 7, 2026

    Hi team,

    Happy to tackle this. Here is how I plan to implement it:

    Solution overview:

    1. Audit storage layout and state invariants ensuring strict auth guards.
    2. Implement deterministic state transitions with safe checked arithmetic.
    3. Add hermetic unit and regression tests covering authorized, unauthorized, and boundary edge cases.
    4. Profile instruction and CPU/gas limits under Soroban host environment.

    Let me know if this aligns with the repository guidelines and assign when convenient.

  9. inioluwanureni90-cell commented on Oct 15, 2026

    @inioluwanureni90-cell
    inioluwanureni90-cell
    on Oct 15, 2026 – with Drips Wave

    @inioluwanureni90-cell has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I’m interested in working on this issue and would appreciate being assigned to it. Thank you.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @inioluwanureni90-cell to this issue.

  10. Ahmad12developer commented on Oct 16, 2026

    @Ahmad12developer
    Ahmad12developer
    on Oct 16, 2026 – with Drips Wave
    Contributor

    @Ahmad12developer has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer
    I like to work on this issue with basic understanding am having for the project

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ahmad12developer to this issue.

  11. lienhoatienphung-svg commented on Oct 16, 2026

    @lienhoatienphung-svg
    lienhoatienphung-svg
    on Oct 16, 2026

    Hi! I have implemented and verified this in #1379 with full unit test coverage and rustfmt compliance.

  12. lienhoatienphung-svg
    added a commit that references this issue on Oct 16, 2026

    feat(registry): add two-step set_admin, accept_admin, and cancel_admi…

    44e1a4e

  13. Codex723 commented on Oct 16, 2026

    @Codex723
    Codex723
    on Oct 16, 2026 – with Drips Wave

    @Codex723 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’d love to implement secure admin rotation with nominate-and-accept, cancellation, and auth snapshot tests while ensuring registration cooldowns remain unchanged; kindly assign it to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Codex723 to this issue.

  14. Holer8 commented on Oct 16, 2026

    @Holer8
    Holer8
    on Oct 16, 2026 – with Drips Wave

    @Holer8 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainers i would like to work on this issue please assign it to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Holer8 to this issue.

  15. adeniyioluwaseyi192007-png commented on Oct 16, 2026

    @adeniyioluwaseyi192007-png
    adeniyioluwaseyi192007-png
    on Oct 16, 2026 – with Drips Wave

    @adeniyioluwaseyi192007-png has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I've gone through the issue carefully and understand the expected result.

    I'm confident I can provide a solution that meets the requirements. I'd appreciate an assignment.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @adeniyioluwaseyi192007-png to this issue.

  16. greatest0fallt1me
    closed this as completedon Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Stellar WaveStellar Wave Program issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions