Skip to content

Connect freeze flag to revenue pool distributions #1218

Closed
Closed
Connect freeze flag to revenue pool distributions#1218
Labels
Stellar WaveStellar Wave Program issue

Description

@greatest0fallt1me
greatest0fallt1me
opened on Sep 27, 2026

Summary

The freeze crate docs say it 'wraps the revenue-pool pause circuit-breaker', but CalloraFreeze only toggles its own DataKey::Frozen; no contract reads it.

Why this matters

Operators may freeze via this contract believing distributions stop, while the revenue pool keeps paying out.

Scope

Either have the revenue pool (and distribute) consult a configured freeze contract via cross-contract call in require_not_paused, or rewrite the crate docs to state it is a standalone harness.

Relevant code in CalloraOrg/Callora-Contracts:

  • contracts/freeze/src/lib.rs
  • contracts/revenue_pool/src/lib.rs
  • contracts/freeze/tests/malformed_freeze.rs

Priority

Medium

Acceptance criteria

  • Freezing blocks revenue pool distribute when wired
  • Unconfigured freeze address keeps current behaviour
  • Integration test covers the cross-contract flow
  • Freeze crate README states the integration model

Validation

cargo test -p callora-freeze && cargo test -p callora-revenue-pool

Non-goals

  • Typo-only, formatting-only, or cosmetic changes.
  • Unrelated refactors, dependency upgrades, or broad rewrites.
  • Removing safeguards or weakening validation to make tests pass.

Contributor application

Before coding, describe the affected modules, proposed state/invariant changes, test strategy, compatibility considerations, and an estimate. Wait for assignment before starting implementation.

PR requirements

Use a feature branch and include Closes #<issue-number>. Address every criterion, map criteria to code and tests, explain security and failure-mode handling, and ensure CI passes.

Quality review

A maintainer will assess correctness, completeness, test depth, compatibility, observability, and adverse-case handling. A substantive implementation is required; merge or CI status alone does not guarantee reward eligibility.

Generated by Claude Code

Activity

  1. greatest0fallt1me
    changed the title [-]Keep leaderboard rank pages deterministic[/-] [+]Add focused test coverage for contracts/settlement/src/migrate.rs[/+] on Sep 27, 2026
  2. greatest0fallt1me
    changed the title [-]Add focused test coverage for contracts/settlement/src/migrate.rs[/-] [+]Connect freeze flag to revenue pool distributions[/+] on Sep 27, 2026
  3. greatest0fallt1me
    added
    Stellar WaveStellar Wave Program issue
    on Sep 27, 2026

  4. Bigtura commented on Sep 27, 2026

    @Bigtura
    Bigtura
    on Sep 27, 2026 – with Drips Wave
    Contributor

    @Bigtura has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hello, I’ve read through the description and have a clear path forward. I’d be glad to take this on

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Bigtura to this issue.

  5. Marvelg256 commented on Sep 29, 2026

    @Marvelg256
    Marvelg256
    on Sep 29, 2026 – with Drips Wave

    @Marvelg256 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hi Maintainer! I'd like to work on this issue. I'm confident I can complete this task and submit a PR within 24 hours.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Marvelg256 to this issue.

  6. Viccodes11 commented on Sep 30, 2026

    @Viccodes11
    Viccodes11
    on Sep 30, 2026 – with Drips Wave

    @Viccodes11 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hello Maintainer, I’ve reviewed the requirements and I’m confident I can resolve this issue effectively. I’d appreciate the opportunity to work on it.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Viccodes11 to this issue.

  7. kingsrichie79-cmyk commented on Sep 30, 2026

    @kingsrichie79-cmyk
    kingsrichie79-cmyk
    on Sep 30, 2026 – with Drips Wave

    @kingsrichie79-cmyk has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I’m available to work on this issue and can start right away

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @kingsrichie79-cmyk to this issue.

  8. Rodrigoue9 commented on Oct 3, 2026

    @Rodrigoue9
    Rodrigoue9
    on Oct 3, 2026

    Hi @maintainers! I'd like to work on this issue. Here is my proposed technical approach:

    Proposed Technical Approach:

    1. Contract Logic Implementation: Implement the required Soroban smart contract logic in Rust, ensuring strict validation, authorization checks (require_auth), and gas optimization.
    2. Storage Layout & State Management: Maintain safe data key patterns, TTL management, and prevent state inconsistency or unauthorized state mutations.
    3. Events & Error Encoding: Emit strongly typed contract events and return descriptive custom errors for all failure modes.
    4. Comprehensive Test Vectors: Implement Rust unit and integration tests using soroban-sdk::Env verifying both success and failure execution paths.

    Key Files:

    • contracts/**/src/lib.rs (contract entrypoints and interface implementations)
    • contracts/**/src/types.rs or storage.rs (types, data keys, and state)
    • contracts/**/src/test.rs (unit tests and integration vectors)

    Verification & Testing:

    • Run cargo test across all contract crates verifying 100% pass rate.
    • Run cargo clippy --all-targets -- -D warnings and cargo fmt --check.
    • Verify Soroban WASM build: soroban contract build.

    Relevant Track Record:

    I have successfully implemented and merged multiple production PRs across the Stellar ecosystem and Web3 open-source projects (e.g., Bitcoindefi/OpenAO #218, cybermax4200/stellar-did-credit #898 & #900, and FindMalek/sonaraem #416).

    Please feel free to assign this issue to me so I can proceed with the implementation. Thank you!

  9. Ranjeet2063 commented on Oct 4, 2026

    @Ranjeet2063
    Ranjeet2063
    on Oct 4, 2026

    Hello maintainers,

    I am interested in taking up Connect freeze flag to revenue pool distributions.

    Solution overview:

    1. Audit storage layout and state invariants ensuring strict auth guards.
    2. Implement deterministic state transitions with safe checked arithmetic.
    3. Add hermetic unit and regression tests covering authorized, unauthorized, and boundary edge cases.
    4. Profile instruction and CPU/gas limits under Soroban host environment.

    Please assign this to me if the plan looks good. Thanks!

  10. AkpakaProsper commented on Oct 15, 2026

    @AkpakaProsper
    AkpakaProsper
    on Oct 15, 2026 – with Drips Wave

    @AkpakaProsper has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Can I work on this issue?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @AkpakaProsper to this issue.

  11. nemeregiftbrown-byte commented on Oct 16, 2026

    @nemeregiftbrown-byte
    nemeregiftbrown-byte
    on Oct 16, 2026 – with Drips Wave
    Contributor

    @nemeregiftbrown-byte has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hi maintainer please love to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @nemeregiftbrown-byte to this issue.

  12. Stanley471 commented on Oct 16, 2026

    @Stanley471
    Stanley471
    on Oct 16, 2026 – with Drips Wave

    @Stanley471 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer, I'd like to work on this issue. I'll start by reviewing the existing code and conventions in the relevant files before making changes, so my implementation stays consistent with the rest of the codebase. I'll cover the requirements and acceptance criteria as listed, add tests where applicable, and verify everything builds/passes locally before opening the PR

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Stanley471 to this issue.

  13. lienhoatienphung-svg commented on Oct 16, 2026

    @lienhoatienphung-svg
    lienhoatienphung-svg
    on Oct 16, 2026

    Hi! I have implemented and verified this in #1386 with full unit test coverage and rustfmt compliance.

  14. comrade10-coder commented on Oct 16, 2026

    @comrade10-coder
    comrade10-coder
    on Oct 16, 2026 – with Drips Wave

    @comrade10-coder has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi, Maintainer I would love to work on this issue I believe I can deliver real quick, kindly assign please

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @comrade10-coder to this issue.

  15. Oluwanifemi18-ux commented on Oct 16, 2026

    @Oluwanifemi18-ux
    Oluwanifemi18-ux
    on Oct 16, 2026 – with Drips Wave

    @Oluwanifemi18-ux has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I’ve read through the issue carefully and believe I can work toward a solution that meets the stated requirements. I’d be glad to contribute.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Oluwanifemi18-ux to this issue.

  16. Dannnyhamps commented on Oct 17, 2026

    @Dannnyhamps
    Dannnyhamps
    on Oct 17, 2026 – with Drips Wave

    @Dannnyhamps has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer, I've reviewed the issue and would like to work on it

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Dannnyhamps to this issue.

  17. cybermax4200 commented on Oct 17, 2026

    @cybermax4200
    cybermax4200
    on Oct 17, 2026 – with Drips Wave
    Contributor

    @cybermax4200 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'd like to take this issue. It covers an important part of the project, and I want to contribute something that fits the existing architecture and development standards and holds up over time.

    I've worked across backend and frontend development, APIs, databases, testing, DevOps, and blockchain-based applications. I'm comfortable reading an unfamiliar codebase, tracking an issue down to its root cause, and writing clean fixes with tests that guard against regressions.

    My plan is to start by reading the existing implementation and project conventions, then build the solution in small, focused steps. I'll test the changes, document them where needed, and keep the code simple so nothing existing breaks. I'll also respond quickly to review feedback so the PR is easy to merge.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @cybermax4200 to this issue.

  18. greatest0fallt1me
    closed this as completedon Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Stellar WaveStellar Wave Program issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions