Repository navigation
test(revenue_pool): keep pause guardian out of unpause and recovery (#1168) - #1381
Closed
lienhoatienphung-svg wants to merge 1 commit into
Closed
lienhoatienphung-svg wants to merge 1 commit into
lienhoatienphung-svg wants to merge 1 commit into
Conversation
lienhoatienphung-svg
force-pushed
the
feature/1168-guardian-unpause-recovery-guards
branch
from
October 16, 2026 07:42
9f80136 to
b0fa2ca
Compare
lienhoatienphung-svg
force-pushed
the
feature/1168-guardian-unpause-recovery-guards
branch
from
October 16, 2026 07:47
b0fa2ca to
8be8123
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1168
Summary
Adds explicit negative authorization and revocation tests proving that the lower-trust pause guardian role can activate
pauseandemergency_pause, but is strictly deniedunpause,recover_from_emergency, and emergency drain entrypoints withRevenuePoolError::Unauthorized, and loses all pause rights onceclear_pause_guardianis called.Acceptance Criteria Mapping
Unauthorized: Covered byguardian_can_pause_but_unpause_fails_with_unauthorizedincontracts/revenue_pool/src/test_emergency.rsandguardian_denied_unpause_after_guardian_pauseincontracts/revenue_pool/tests/emergency_auth_snap.rs.Unauthorized: Covered byguardian_can_enter_emergency_pause_but_only_admin_can_recoverincontracts/revenue_pool/src/test_emergency.rsandguardian_denied_recover_from_emergencyincontracts/revenue_pool/tests/emergency_auth_snap.rs.clear_pause_guardian, guardian pause fails: Covered bycleared_guardian_cannot_pause_or_emergency_pauseincontracts/revenue_pool/src/test_emergency.rsandguardian_denied_pause_after_clear_pause_guardianincontracts/revenue_pool/tests/emergency_auth_snap.rs.Guardian-Denied Entrypointstable and enforced by dedicated snapshot tests incontracts/revenue_pool/tests/emergency_auth_snap.rs.Validation
cargo test -p callora-revenue-pool guardianPayout Wallet (Base Mainnet USDC / EVM):
0x3806cd592a508d1992Ed007C2F53de251C2E7452