Repository navigation
feat(batch_claim): settle batch claims with actual token payouts (#1198) - #1385
Closed
lienhoatienphung-svg wants to merge 1 commit into
Closed
lienhoatienphung-svg wants to merge 1 commit into
lienhoatienphung-svg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1198
Summary
Wires real reward-token payouts into
CalloraBatchClaim:StorageKey::RewardToken,init_with_token(env, admin, reward_token),set_reward_token(env, caller, reward_token), andget_reward_token(env).batch_claimand verifiestoken::Client::new(&env, &token_addr).balance(&contract_addr) >= total_claimedbefore mutating any state (returningBatchClaimError::InsufficientBalanceif underfunded).pending_amountafter markingClaimConsumedandrecord.settled = true, and includes the reward token inclaims_settledevents.contracts/batch_claim/docs/storage.mdto match the contract'sStorageKeylayout.Acceptance Criteria Mapping
test_batch_claim_transfers_reward_tokens_to_each_claimant.test_batch_claim_insufficient_contract_balance_fails_without_state_change.init_with_tokenandclaims_settledinclude the configuredreward_tokenaddress.contracts/batch_claim/docs/storage.md.Validation
cargo test -p callora-batch-claimPayout Wallet (Base Mainnet USDC / EVM):
0x3806cd592a508d1992Ed007C2F53de251C2E7452