Repository navigation
Conversation
Jah-yee
force-pushed
the
fix/last-error-typo
branch
from
October 11, 2026 21:05
aaddb2c to
7f6006e
Compare
Jah-yee
force-pushed
the
fix/last-error-typo
branch
from
October 12, 2026 10:42
7f6006e to
cec41e4
Compare
Wkhanex
reviewed
Oct 12, 2026
There was a problem hiding this comment.
Verified the corrected diagnostic with a synthetic two-layer, five-column profile: a zero material number in the first layer raises The "material number" column should be all positive, except for the last layer. A zero material number in the final layer is accepted, so the corrected wording matches the actual exception rule. I ran these checks using the extracted complete validator and its numeric helpers on Python 3.12/NumPy; the full library, tox and example notebooks were not run, and this is not a merge approval.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a typo in the error message emitted by
check_Vs_profile_format():"last error" → "last layer".
Changes
PySeismoSoil/helper_generic.py: Changed the ValueError message for invalid
material numbers from
except for the last errortoexcept for the last layer, consistent with the thickness check above it.tests/test_class_Vs_profile.py: Updated
test_Vs_profile_format__case_10to match the full error message (preventing future regressions on this
specific wording).
Testing
The fix was verified by running the reproduction case from issue #121:
Closes #121