Skip to content

acamd: the deliberate-offset allowance may be consumed only by the correction that used it (wrong-object exposure, stacked on #484) #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cfremling wants to merge 1 commit into from
Closed

acamd: the deliberate-offset allowance may be consumed only by the correction that used it (wrong-object exposure, stacked on #484) #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions acamd/acam_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3643,8 +3643,15 @@ logwrite( function, message.str() );
// (ACQUIRE_TCS_MAX_PUTONSLIT_OFFSET). The ACQUIRE path uses tcs_max_offset
// and is unaffected.
//
// `large` is latched HERE, and only the correction that was decided under
// the allowance may consume it below. Clearing the flag unconditionally
// after a send let an ordinary correction consume an allowance that
// offset_goal armed while that correction's blocking pt_offset was still
// in flight (UT 2026-10-06 09:10:41, ZTF26abydudp: armed at .026,
// cleared at .031, the 136" science offset refused against 60").
const bool large = this->allow_large_offset.load();

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Tie the allowance to the goal generation

If offset_goal updates acam_goal and arms the flag after ra_off/offset were calculated but before this load, the stale ordinary correction is incorrectly classified as large; it can be sent under the expanded cap and then clear the allowance at line 3704. The next iteration computes the actual deliberate science offset without its allowance, so an offset above 60″ is rejected and exposure can remain on the offset star. A boolean snapshot cannot associate an allowance with the goal that created it; this needs synchronization or a generation/token captured alongside the goal.

Useful? React with 👍 / 👎.

double maxoffset = this->tcs_max_offset;
if ( this->allow_large_offset.load() ) {
if ( large ) {
// A deliberate goal offset is correct by construction and must not
// be capped as a guide correction, whatever mode the loop is in
// when the correction lands.
Expand All @@ -3657,7 +3664,7 @@ logwrite( function, message.str() );
message.str(""); message << "[WARNING] calculated offset " << offset << " not below max "
<< maxoffset << " and will not be sent to the TCS";
logwrite( function, message.str() );
this->allow_large_offset.store(false); // deliberate-offset allowance consumed even when rejected
if ( large ) this->allow_large_offset.store(false); // consumed even when rejected -- only by the correction that used it

// Match found but failure to send an offset is considered an attempt
// so attempts is incremented.
Expand Down Expand Up @@ -3694,7 +3701,7 @@ logwrite( function, message.str() );
if ( should_offset ) {
// send offset to TCS here (returns when offset is complete)
if ( iface->tcsd.pt_offset( ra_off*3600., dec_off*3600., OFFSETRATE )==ERROR) break;
this->allow_large_offset.store(false); // deliberate-offset allowance consumed
if ( large ) this->allow_large_offset.store(false); // consumed -- only by the correction that used it
std::this_thread::sleep_for( std::chrono::seconds(1) );
}

Expand Down
Loading