Skip to content

Drop the lris2 submodule and stop CI depending on private instruments - #49

Merged
mikelangmayr merged 3 commits into
mainfrom
mike/drop-lris2-submodule
Oct 7, 2026
Merged

mikelangmayr merged 3 commits into
mainfrom
mike/drop-lris2-submodule

Conversation

@mikelangmayr

@mikelangmayr mikelangmayr commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
  • LRIS2 builds from its own repository with camerad as a dependency, so its sources no longer need to sit under camerad/Instruments; removes the submodule entry and its gitlink
  • The docs and emulator workflows checked out submodules and built -DINSTRUMENT=hispec_tracking_camera, but that repository is private, so every run failed at checkout with "Repository not found". They now build the core with no instrument
  • The instrument was incidental to what those jobs test: frame outputs, SHM and FITS writing, the Python module driving the emulator, and the install rules. None of it is instrument-specific, and instrument builds are covered by each instrument's own CI
  • Drops the cryoscope emulator job
  • Drops the nightly submodule update job, which failed every night on the same private repositories and has nothing left to bump
  • cmake-workflow.yml is unchanged: it already checks out without submodules and only selects an instrument on manual dispatch, which is why it was the one job still passing

@mikelangmayr mikelangmayr changed the title Drop the lris2 instrument submodule Drop the lris2 submodule and stop CI depending on private instruments Oct 7, 2026
@mikelangmayr
mikelangmayr merged commit b75d689 into main Oct 7, 2026
4 of 5 checks passed
@mikelangmayr
mikelangmayr deleted the mike/drop-lris2-submodule branch October 7, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants