Repository navigation
Reference instrument exercises the instrument override points in CI - #50
Merged
Merged
Conversation
reference_instrument/ builds its own camerad and module against the surrounding core through FetchContent, pinned to the #47 merge overrides the instrument command, configure_instrument and mode selection reference-instrument-test runs it against the emulator and checks command dispatch, not frame readout is_instrument_command override is temporary until the dispatch fix
astronomerdave
requested review from
mikelangmayr,
prkrtg and
scizen9
as code owners
October 8, 2026 20:17
mikelangmayr
approved these changes
Oct 9, 2026
mikelangmayr
left a comment
mikelangmayr
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Good idea to have the reference instrument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required to meet camera 2.0 design
This adds
reference_instruemnt/, and insturment that belongs to no projkect. It is built the want an instrument repo builds, composing the core withFetchContentat a pinned commit, except that inside the core it builds the surrounding tree instead of fetching.It overrides all three instrument specialization points.
refvalueis an instrument command,configure_instrument()readsREFERENCE_VALUEfrom its cfg, and mode selection adds aREFERENCEmode derived fromSINGLE.The new
reference-instrument-testjob runs itscameradagainst the emulator, checks each override point over the socket, and imports its Python module. It checks command dispatch, not frame readout, sinceexposereplies DONE whateverdo_expose()returns. (I'll fix this later)The
is_instrument_commandoverride is only there because the server currently consults it before every command. It goes away with the dispatch fix.No change to the core's code
Verified locally, including breaking each override point in turn to see its check fail.