Repository navigation
Install the vendor drivers as a uv workspace - #259
Merged
Merged
Conversation
prkrtg
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/hispec/driver/are vendored submodules, so their declared dependencies were never resolved and had to be repeated in hispec'spyproject.tomlby hand. That had drifted:telnetlib3andpymcprotocolwere declared by the pdu and fiber-switcher drivers and installed by nothing.telnetlib3survived on the host only because pip never removes anything, so moving to uv pruned it.[tool.uv.workspace]keeps them vendored and editable while resolving their dependencies into the same environment, so the hand-mirroring stops being something that can drift.override-dependenciesforces onehardware_device_baseref. The drivers pin it to v1.0.0, v1.0.1 and unpinned between them, and uv allows one URL per package, so nothing resolves otherwise. Today they all get whatever the default branch is, which is none of those, so this is more deliberate than the status quo.install.shusesuv sync --all-packages; plainuv synclocks the members but installs only the root project's closure, which leaves the driver dependencies out and looks like success.paramikoadded to hispec. The pdu driver imports it for the DLI DC3's SSH transport and declares it nowhere; it belongs upstream and comes back out once that lands.pycameradstops being a submodule. It was both vendored and a git dependency ofcamera_daemon, which uv rejects, and nothing imported the vendored copy excepttracking_camera/camera.pythrough a relative import, now pointed at the distribution.hspower_*daemon unstartable: the missingtelnetlib3, the missingparamiko, and a barefrom emat08_10 import trailing_intindli_dc3.pythat only resolves once the driver is a real distribution.EatonEMATandDlidc3import,daemons/hspower/eaton_pdu --helpruns, drivers still resolve to their vendored paths, and the nine tracking camera tests pass.pytestlands in the venv becausesrsdeclares it as a runtime dependency. That is fixed in the driver, not here.src/hispec/driver/pycameraddirectory is left behind, since git does not remove a submodule working tree. Nothing imports it; delete it.