Repository navigation
Take the operator CLI from instrumentctl - #262
Merged
Merged
Conversation
Contributor
|
Hmm, I'm thinking because of this change it might be better to split out now to a generic code base. We can move everything in cli/ into its own package (instrumentctl?). It'll depend on nothing instrument-specific. And when each instrument depends on it, ships its own instrument.toml, and declares its own console script ( |
Contributor
Author
|
@prkrtg Done in this PR, and instrumentctl is up at: https://github.com/CaltechOpticalObservatories/instrumentctl One deviation: the console script stays |
prkrtg
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/hispec/cli/instrument.toml, and the logic moved toinstrumentctl, a dependency shared with other instruments.python -m hispec.cli. 1271 lines leave.[project.scripts] hispec = "hispec.cli:main"is unchanged, soinstall.sh, the polkit rule and the/usr/local/binwrapper need no edits.repo_hint, which matters: the old code found the checkout by walking up from__file__, and once the walk starts in site-packages every host silently falls back to/opt/hispec/app. The instrument is what knows where it lives.requires-pythonmoves to>=3.11, sinceinstrumentctluses stdlibtomllib. The deployment venv runs 3.14.install.shbefore.hispec-daemon@unit and polkit rule move into a[legacy]section, so that history travels with this instrument rather than with the shared code.uv syncpullsinstrumentctlfrom git, and the installedhispecconsole script runsdeploy,status,logsanddoctoragainst a fixture host tree with output identical to before. Separately proven generic by driving the same code from a four-line lris2 config.src/hispec/cli/as the CLI's home.