Repository navigation
Hand host setup to hispec install - #265
Merged
Merged
Conversation
prkrtg
approved these changes
Oct 14, 2026
prkrtg
left a comment
Contributor
There was a problem hiding this comment.
Good to merge, for future food of thought we might want to think about alternative ways to run the daemons via shell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.shgoes from 235 lines to 71: the root check, the pinned uv bootstrap,uv sync, thenexec hispec install. Everything after the virtualenv now lives in instrumentctl and is shared.bin/hispecandbin/hispec-enableare deleted here and rendered fromsrc/hispec/cli/instrument.tomlinstead.instrumentctlat v0.2.0, where the unit derives each instance's config as/etc/hispec/<name>.yamlrather than readingHISPEC_CONFIG. Every one of the 41 instance files already set exactly that path, so no daemon changes behaviour; the now-unread variable is removed from all of them, and from the docs that described it.display_name = "HISPEC", sosystemctl statuskeeps readingHISPEC hardware daemonrather thanhispec.hispec-daemon@migration block is gone: every host is onhispec@.doctorstill reports a leftover old unit through the[legacy]config.status -vresolves the config to the derived path,deployfinds and copies it, anddoctorreports no stale-variable warning.Deploy order matters, because the unit and the instance files change together.
install.shrenders the new unit before deploying anything, which is the normal flow. The combination to avoid is stripped instance files against a unit that has not been re-rendered, whereExecStartwould get an empty-c: