Repository navigation
Conversation
sjavis
added this pull request to stack #262
September 21, 2026 09:39
This was
linked to
issues
Sep 21, 2026
sjavis
force-pushed
the
batching-buffer-period
branch
from
September 29, 2026 18:07
31b5562 to
8cb9c15
Compare
sjavis
force-pushed
the
batching-combine-trajectories
branch
2 times, most recently
from
October 1, 2026 07:15
478c746 to
d6dc6cf
Compare
sjavis
force-pushed
the
batching-buffer-period
branch
from
October 1, 2026 07:15
8cb9c15 to
2ca45b5
Compare
Only tracks starting in the main batch periods are retained.
sjavis
force-pushed
the
batching-combine-trajectories
branch
from
October 2, 2026 12:43
d6dc6cf to
31ac11b
Compare
sjavis
force-pushed
the
batching-buffer-period
branch
from
October 2, 2026 12:43
2ca45b5 to
1cc7528
Compare
Fixes a bug in _combine_trajectories that causes failure when there is more than one trajectory in a batch.
sjavis
force-pushed
the
batching-buffer-period
branch
from
October 2, 2026 12:51
1cc7528 to
fae4b04
Compare
sjavis
removed this pull request from stack #262
October 5, 2026 16:27
Collaborator
Author
|
Replaced by #274 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the batching interface to take the time period and batch interval as input arguments rather than number of iterations. It now automatically subspaces the input files to the relevant time period and saves them to the batch directory. There are also options to say a file doesn't vary in time or should be kept in memory for preprocessing. Closes #192
It also enables setting buffer periods with the
buffer_periodandstart_buffer_periodoptions toBatchingConfig. When combining the output files it will only keep the tracks that start within the main batch periods. Therefore,start_buffer_periodhas been set to just a day by default because if it is in any of that period then it is assumed to be in the previous batch. Closes #193