Repository navigation
Add basic unit tests for the ML tracker helpers and parameters - #270
Merged
Merged
Conversation
surbhigoel77
marked this pull request as draft
September 29, 2026 11:59
surbhigoel77
marked this pull request as ready for review
October 5, 2026 09:44
Member
Author
|
@sjavis Some tests are failing as the ml-integration branch is not merged yet. Once it is merged these tests would pass |
sjavis
reviewed
Oct 9, 2026
sjavis
left a comment
sjavis
left a comment
Collaborator
There was a problem hiding this comment.
I'm mostly happy with this. I have a few suggestions. The main one being about reducing the number of test classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR contains unit tests for each functionality within the ML Tracker.