Update engine to use (some) packaged libraries instead of files - #184
Open
hobbsythe6th wants to merge 35 commits into
Open
Update engine to use (some) packaged libraries instead of files#184hobbsythe6th wants to merge 35 commits into
hobbsythe6th wants to merge 35 commits into
Conversation
…com/hobbsythe6th/Candlestick into engine-package.json-update-betterer
hobbsythe6th
marked this pull request as draft
August 8, 2026 09:46
Contributor
Author
|
new bugs found, working on it currently |
Contributor
Author
|
fixed and added a lot of checks! may need testing tho |
hobbsythe6th
marked this pull request as ready for review
August 11, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This included migrating Gulp to Rolldown, as Gulp does not have a resolver. Also, since Rolldown comes as a Vite dependency, I also merged the Vite migration into this. There are probably a lot of bugs, but all the ones I found with the new setup were patched (except for one: on opening the page the timeline is only partially rendered. But it re-renders after you close the welcome modal so I don't think that it's very significant.)
I also modified the index.html to load paper and jQuery as separate scripts, as I didn't have the patience to add any integration.
Since this was really hard, I started out by using Webpack, so that's why the first few commits have it. The Rolldown switch came later.
BTW, I didn't make Croquis a package because I didn't have the patience to figure the package structure out, so I just stuck with the local file. Also, some libraries like convertRange are from stackoverflow so I left those alone.