fix(scan): reject unreachable manual URLs and soften transport errors by posthog-eu[bot] · Pull Request #3326 · Cap-go/capgo.app

posthog-eu · 2026-09-14T11:55:24Z

Summary (AI generated)

Fixes two failures on the mobile scan screen (src/pages/scan.vue), plus a
resilience gap on the preview payload route.

Reject unreachable manual URLs before submit. The manual field prepended
https:// to any input, so a single word with no dot ("capago" ->
https://capago) parsed fine and went straight to the native downloader,
which failed with a raw platform DNS error. Submission now requires a dotted
domain, an IP literal, or an explicit local host (isReachableHttpUrl).
Plain-language transport errors. Network failures no longer echo the raw
platform string ("A server with the specified hostname could not be found").
They map to That address could not be reached. Check the link and your connection, then try again. The raw error is still kept in the debug log.
Payload route survives a DB hiccup. files/preview.ts now passes the
underlying database error as the simpleError cause, so onError classifies
a transient Postgres timeout as a retryable 503 upstream_unavailable
instead of a bare 500 (or a misleading 400 bundle_not_found).

The pure URL/error helpers moved into src/services/previewLinks.ts so they can
be unit-tested.

Test plan (AI generated)

bunx vitest run tests/preview-links.unit.test.ts tests/preview-payload-db-error.unit.test.ts (added):
- bare host (https://capago) is rejected; dotted domains, IPs, localhost,
  and [::1] are accepted.
- manual-URL normalization keeps explicit schemes and assumes https otherwise.
- native/browser transport strings are detected; unrelated errors are not.
- a transient DB error on the payload lookup is threaded as the error cause and
  classified transient (drives the 503); a genuine missing bundle stays a
  non-transient 400.
bun typecheck and eslint on the touched files pass.

Screenshots (AI generated)

Not captured. The affected states are native-download failure paths (iOS
updater / fetch transport errors) that cannot be reproduced in the web preview.
The change is input validation plus error copy; behavior is covered by the unit
tests above.

Checklist

My code follows the code style of this project and passes lint on the
touched files.
My change requires a change to the documentation.
I have updated the documentation accordingly.
My change has adequate test coverage (unit tests added).
I have tested my code manually (verified via unit tests; native download
flow not reproducible here).

Created with PostHog Desktop from this inbox report.

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

coderabbitai · 2026-09-14T11:55:32Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 66b764d0-c482-4f3a-a985-7214e4289213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codspeed · 2026-09-14T11:57:25Z

Merging this PR will improve performance by 82.22%

⚡ 1 improved benchmark
✅ 42 untouched benchmarks
⏩ 2 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`/updates manifest response with metadata`	255.5 µs	140.2 µs	+82.22%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing posthog-self-driving/fixscan-validate-manual-preview-urls-56a607 (d20b41e) with main (ea1a1ed)}

2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

cursor · 2026-09-23T16:45:31Z

@coderabbitai review

cursor · 2026-09-23T16:51:13Z

@cursor review

github-actions · 2026-09-23T16:57:22Z

@coderabbitai review

cursor · 2026-09-23T17:03:49Z

@coderabbitai full review

github-actions · 2026-09-23T17:19:25Z

@coderabbitai review

cursor · 2026-09-23T17:45:24Z

@coderabbitai review

github-actions · 2026-09-23T17:45:35Z

@coderabbitai review

cursor · 2026-09-23T17:50:00Z

@coderabbitai help

riderx · 2026-09-23T17:52:08Z

@coderabbitai review

riderx · 2026-09-23T18:02:03Z

@coderabbitai full review

riderx · 2026-09-23T18:25:17Z

@coderabbitai full review

riderx · 2026-09-23T18:42:37Z

@coderabbitai full review

coderabbit-trigger:af08a765ffa515ef4ac82848659991210f47104e

TorichanCapgo · 2026-09-23T18:53:09Z

@coderabbitai full review

Please review current HEAD. Ignore prior CI-only commits that only tipped CodeRabbit; a cleanup to product-only diff is in flight if still present.

The manual URL field prepended `https://` to any input and accepted it as long as `new URL()` parsed, so a single word with no dot (for example "capago" -> "https://capago") reached the native downloader and failed with a raw iOS message ("A server with the specified hostname could not be found"). - Reject an http(s) host with no dot, IP literal, or explicit local host before submitting or downloading, via `isReachableHttpUrl`. - Map transport failures to plain guidance ("That address could not be reached...") instead of echoing the raw platform error, via `isNetworkReachabilityError`; the raw error stays in the debug log. - Preview payload route: pass the underlying DB error as the `simpleError` cause so `onError` classifies a transient Postgres hiccup as a retryable 503 instead of a bare 500 / misleading 400. Extracted the pure URL helpers into `previewLinks.ts` for unit coverage. Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>

sonarqubecloud · 2026-09-23T19:00:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

TorichanCapgo · 2026-09-23T19:05:28Z

@coderabbitai full review

TorichanCapgo · 2026-09-23T19:27:44Z

@coderabbitai full review

posthog-eu Bot deployed to deepsec-pr September 14, 2026 11:55 Active

posthog-eu Bot marked this pull request as ready for review September 14, 2026 12:22

cursor Bot deployed to deepsec-pr September 23, 2026 16:57 Active

cursor Bot deployed to deepsec-pr September 23, 2026 17:19 Active

cursor Bot deployed to deepsec-pr September 23, 2026 17:45 Active

cursor Bot deployed to deepsec-pr September 23, 2026 17:52 Active

cursor Bot deployed to deepsec-pr September 23, 2026 18:01 Active

cursor Bot deployed to deepsec-pr September 23, 2026 18:25 Active

cursor Bot deployed to deepsec-pr September 23, 2026 18:42 Active

cursor Bot force-pushed the posthog-self-driving/fixscan-validate-manual-preview-urls-56a607 branch from af08a76 to d20b41e Compare September 23, 2026 18:53

cursor Bot deployed to deepsec-pr September 23, 2026 18:53 Active

Uh oh!

Conversation

posthog-eu Bot commented Sep 14, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary (AI generated)

Test plan (AI generated)

Screenshots (AI generated)

Checklist

Uh oh!

coderabbitai Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codspeed Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 82.22%

Performance Changes

Footnotes

Uh oh!

cursor Bot commented Sep 23, 2026

Uh oh!

cursor Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

cursor Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

cursor Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

cursor Bot commented Sep 23, 2026

Uh oh!

riderx commented Sep 23, 2026

Uh oh!

riderx commented Sep 23, 2026

Uh oh!

riderx commented Sep 23, 2026

Uh oh!

riderx commented Sep 23, 2026

Uh oh!

TorichanCapgo commented Sep 23, 2026

Uh oh!

sonarqubecloud Bot commented Sep 23, 2026

Quality Gate passed

Uh oh!

TorichanCapgo commented Sep 23, 2026

Uh oh!

TorichanCapgo commented Sep 23, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

posthog-eu Bot commented Sep 14, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Sep 14, 2026 •

edited

Loading

codspeed Bot commented Sep 14, 2026 •

edited

Loading