fix(admin): include E, F, and G in onboarding animation analytics

[WcaleNieWolny]

Summary (AI generated)

• Include onboarding versions 5.E, 5.F, and 5.G in the existing admin channel-animation graph and stage metrics.
• Keep viewers deduplicated by person and animation stage, with the existing first-run/replay rules and production-host filter.
• Add a regression test for the complete guided cohort and refresh the required generated code graph using the release-pinned Graphify version (0.8.31). Generated graph files account for the larger diff; the functional fix and test are confined to two files.

Motivation (AI generated)

All three versions use the same guided channel animations. The graph previously filtered only 5.E, silently excluding viewers assigned to the combinations represented by 5.F and 5.G.

Business Impact (AI generated)

The admin dashboard can evaluate animation engagement across the entire guided treatment cohort instead of an incomplete subset. Database-backed treatment/control channel-creation outcomes and experiment assignment remain unchanged. No migration, customer-facing UI change, or additional event collection is required.

Test Plan (AI generated)

• Confirm the new regression test fails before the query change and passes afterward (6 targeted tests).
• bun run lint (0 errors; 36 existing warnings) and bun run lint:backend.
• Lint the changed unit test with ESLint.
• TZ=UTC bun run test:unit: 327 files / 2,855 tests passed. An initial local-timezone run exposed four existing date-sensitive native-device statistics failures; those eight tests pass in UTC.
• bun run typecheck:backend.
• Production API Worker bundle: Wrangler deploy --env=prod --minify --dry-run (no deployment performed).
• Execute the exact generated HogQL against live production events; all three animation stages return combined, deduplicated metrics.
• Refresh the generated code graph with the same pinned generator version as release automation.
• Verify remote CI and automated review (CodeRabbit approved without actionable comments).
• Prove stable-green twice at least five minutes apart; evidence will be recorded in a PR comment.

Generated with AI.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8306b952-7bc2-4a02-b22c-7b66da70ed8e

📥 Commits

Reviewing files that changed from the base of the PR and between dea881a and 14832d3.

📒 Files selected for processing (4)

• graphify-out/GRAPH_REPORT.md
• graphify-out/graph.json
• supabase/functions/_backend/utils/ab_test_channel_creation.ts
• tests/admin-ab-test-channel-creation.unit.test.ts

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• Cap-go/capacitor-updater (manual)

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The analytics query now accepts onboarding versions 5.E, 5.F, and 5.G. Tests verify the allowlist and confirm that viewer grouping does not include onboarding_version.

Changes

Onboarding analytics version filtering

Layer / File(s)	Summary
Query allowlist and validation supabase/functions/_backend/utils/ab_test_channel_creation.ts, tests/admin-ab-test-channel-creation.unit.test.ts	The query builds an allowlist for versions 5.E, 5.F, and 5.G and filters events against that allowlist. Tests verify all three versions and grouping by person_id, stage without onboarding_version.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 14832

The analytics expansion is supported by the stated tests and upstream version-label contract, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely identifies the main change: including onboarding versions 5.E, 5.F, and 5.G in animation analytics.
Description check	✅ Passed	The description provides a clear summary, motivation, business impact, detailed test plan, and notes that no customer-facing UI change exists. The Screenshots section is not required for this backend …

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codspeed]

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks¹

---

_{Comparing wolny/fix-admin-animation-cohorts (14832d3) with main (dea881a)}

Footnotes

1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[WcaleNieWolny]

PR-ready verification (AI generated)

Stable-green: yes. Every applicable merge gate passed twice for the unchanged PR state.

• PR: fix(admin): include E, F, and G in onboarding animation analytics #3345
• Head: 14832d3f81f855240b0f03a1b4644108738f3c93
• Base: main@dea881a23a9a443a93a332d8984c5a11bcab9c9c
• Local verification: frontend lint (0 errors; 36 existing warnings), backend lint, changed-test ESLint, backend typecheck, production API Worker dry-run build, exact live HogQL validation, generated code-graph refresh, and clean working tree/diff checks passed.
• Tests: TZ=UTC bun run test:unit — 327 files / 2,855 tests passed. Targeted analytics regression: 6 tests passed; release-scope regression: 23 tests passed. An initial local-timezone run exposed four existing date-sensitive native-device statistics test failures; that file passed in UTC, as did the full suite.
• Remote checks: 72 passed; 22 conditional/non-required checks skipped as accepted by repository scope rules. No failed, cancelled, or pending current checks. No non-required failures.
• Reviews: required approval satisfied by CodeRabbit; no change requests, 0 unresolved conversations, and 0 pending requested reviewers.
• Mergeability: MERGEABLE / CLEAN; no unmet repository requirements.
• Observation A: 2026-09-16 12:22:43 UTC.
• Observation B: 2026-09-16 12:28:07 UTC (324 seconds later).

The functional change includes 5.E, 5.F, and 5.G in the existing animation graph while retaining per-person/per-stage deduplication. Database treatment/control outcomes remain unchanged. This PR has not been merged or deployed.

Generated with AI.