Conversation
- Implemented a warning mechanism in the CLI for cases where direct updates are enabled but the upload does not use delta, prompting users to utilize the `--delta` option. - Introduced new functions to handle direct update detection and warning logic. - Updated documentation to reflect the new warning behavior. - Enhanced unit tests to cover the new functionality and ensure proper event tracking for direct updates without delta.
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
|
rihoarvutikonto
left a comment
There was a problem hiding this comment.
Unique: direct-update-without-delta warn fires for --external uploads where --delta is forced off and cannot be used.
| log.info(`[Verbose] Delta updates: ${options.delta ? 'enabled' : 'disabled'}`) | ||
| } | ||
|
|
||
| if (shouldWarnDirectUpdateWithoutDelta({ |
There was a problem hiding this comment.
options.external forces options.delta = false just above (line 1734–1735: "not available with external URLs"), then this still warns and tells the operator to bundle upload --delta.
That advice cannot work for --external / S3 uploads. The Bento/PostHog event (Direct Update Without Delta, channel: 'app-error') will also fire on every external upload of a direct-update app, including CI.
Skip the warn when delta is impossible (options.external or !fileConfig.partialUpload), e.g. pass that into shouldWarnDirectUpdateWithoutDelta.
warnDirectUpdateWithoutDelta also await sendEvent(...) with no try/catch. Other upload telemetry is best-effort; if this throw lands, a warning aborts the bundle. Swallow sendEvent errors here.



--deltaoption.Summary
Test plan
Screenshots
Checklist
bun run lint:backend && bun run lint.accordingly.
my tests
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.