Skip to content

fix(onboarding): show Getting started for pending v3/v4 checklist steps - #3394

Open
WcaleNieWolny wants to merge 1 commit into
mainfrom
wolny/onboarding-navbar-checklist
Open

WcaleNieWolny wants to merge 1 commit into
mainfrom
wolny/onboarding-navbar-checklist

Conversation

@WcaleNieWolny

@WcaleNieWolny WcaleNieWolny commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

V3 and v4 OTA apps can have a pending setup checklist while the sidebar uses the older features ledger to decide whether “Getting started” appears. The sidebar now checks the app's todo-list steps for those versions: it stays visible while any step is pending and disappears once all steps are done or skipped. V1/v2 retain their feature-based behavior, and the existing dismiss action still hides the entry.

Validation: bun lint, frontend typecheck, production build, and 50 focused unit tests passed. The full unit run passed 3,226 tests and failed four native-device-stats.unit.test.ts cases; all four fail identically on untouched main.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved Getting Started navigation visibility across onboarding checklist versions.
    • The navigation now reflects incomplete setup steps for newer onboarding flows while preserving existing behavior for legacy flows.
    • Completed or skipped steps no longer keep the navigation visible.
    • Dismissed Getting Started navigation remains hidden.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 70631a3b-858f-4260-8fc5-380491eda491

📥 Commits

Reviewing files that changed from the base of the PR and between 4514957 and e394db6.

📒 Files selected for processing (3)
  • src/components/dashboard/GettingStartedNav.vue
  • src/utils/appOnboardingProgress.ts
  • tests/app-onboarding-progress.unit.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • Cap-go/capacitor-updater (manual)

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The change makes onboarding navigation visibility version-aware. Versions 3 and 4 use step statuses, versions 1 and 2 retain feature-based behavior, and unsupported versions return false. The dashboard now passes raw onboarding data to the utility.

Changes

Onboarding navigation

Layer / File(s) Summary
Version-aware visibility rules
src/utils/appOnboardingProgress.ts
shouldShowGettingStartedNav parses raw onboarding data and applies step-based rules for versions 3 and 4, legacy feature-based rules for versions 1 and 2, and false for other versions.
Dashboard wiring and validation
src/components/dashboard/GettingStartedNav.vue, tests/app-onboarding-progress.unit.test.ts
The dashboard passes raw onboarding data. Tests cover navigation visibility for versions 1 through 5 and multiple step statuses.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: riderx

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the behavior change and includes validation results, but it does not use the required Summary, Test plan, Screenshots, and Checklist sections. It also omits the required check… Reformat the description with all template sections. Add explicit test steps, include screenshots or state why they are not available, and complete every checklist item with the applicable boxes marked.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: showing the Getting Started navigation for pending V3 and V4 checklist steps.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the behavior change and includes validation results, but it does not use the required Summary, Test plan, Screenshots, and Checklist sections. It also omits the required checklist responses and screenshots for a frontend behavior change.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing wolny/onboarding-navbar-checklist (e394db6) with main (4514957)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sonarqubecloud

Copy link
Copy Markdown

This branch was successfully deployed

1 active deployment
deepsec-pr — e394db65 Deployed Sep 20, 2026 by WcaleNieWolny via Scan PR changes #7406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant