fix(onboarding): show Getting started for pending v3/v4 checklist steps - #3394
WcaleNieWolny wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change makes onboarding navigation visibility version-aware. Versions 3 and 4 use step statuses, versions 1 and 2 retain feature-based behavior, and unsupported versions return ChangesOnboarding navigation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the behavior change and includes validation results, but it does not use the required Summary, Test plan, Screenshots, and Checklist sections. It also omits the required checklist responses and screenshots for a frontend behavior change. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
|



V3 and v4 OTA apps can have a pending setup checklist while the sidebar uses the older
featuresledger to decide whether “Getting started” appears. The sidebar now checks the app's todo-list steps for those versions: it stays visible while any step is pending and disappears once all steps are done or skipped. V1/v2 retain their feature-based behavior, and the existing dismiss action still hides the entry.Validation:
bun lint, frontend typecheck, production build, and 50 focused unit tests passed. The full unit run passed 3,226 tests and failed fournative-device-stats.unit.test.tscases; all four fail identically on untouchedmain.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit