Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review finding R21.
Default RPC and broadcast overloads such as
Update(int)andUpdate(string)previously emitted duplicate receive events and delegates. Qualify conflicting receive symbols with their existing signature-based message IDs, preserve single-method and explicit receive APIs, and retain inherited receive names, including interfaces in older compiled libraries. Document the subscription names in the README.Validation:
dotnet test Cat.Network.sln -c Release --no-restore --nologopasses all 250 tests (155 runtime, 53 analyzer, 42 generator), including 22 new overload cases that run the analyzer and generator together and dispatch both overloads to distinct handlers. The original regressions failed before the fix; wire IDs and explicit handlers remain unchanged.Composition with #24: use
ReceiveNamefor generated event/delegate/raise stems while retaining #24's escapedIdentifierfor send/explicit method names and its scoped local-name allocation.