Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review finding R25.
Collection declarations such as
NetworkList<int[]>,NetworkDictionary<int, int[]>, andNetworkList<T>caused AD0001 because the analyzer cast arbitrary element symbols toINamedTypeSymbol. The array declarations could otherwise compile successfully and reach an unsupported runtime codec. Guard the network-object inheritance check with named-symbol matching so unsupported symbol kinds return the existing CN0015 error at the collection property instead of crashing the analyzer.Add 26 analyzer cases covering arrays, dynamic values, type parameters and constraints, nested array/generic struct fields, dictionary keys, and simultaneous invalid keys and values. Add 14 combined generator/analyzer cases confirming that unsupported array schemas are rejected even when generated C# compiles, and that scalar, string, Guid, network-object, public-field struct, and nullable collections still analyze and emit successfully. The generator test project references the analyzer to run these combined checks.
Validation on .NET SDK 10.0.400 / net8.0:
The change preserves supported collection types, existing CN0016 key validation, runtime behavior, public APIs, and wire formats. Previously accepted unsupported element symbols now correctly produce an analyzer error. No diagnostics are added or renumbered.