Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review finding R27.
A
net8.0consumer defaults to C# 12, but Cat.Network declarations and generatedfieldaccessors require C# 14. The compiler extensions also reference Roslyn 5.6.0. Setup omitted these requirements, and CI explicitly installed only SDK 8 without selecting a compiler SDK, allowing incidental runner installations to determine builds.Pin the tested SDK 10.0.400 baseline in
global.json, allowing stable patches within the same feature band, and set C# 14 explicitly in the repository projects and consumer example. Document the separate .NET 8 runtime requirement. Both CI jobs now install the pinned compiler SDK plus SDK 8 for the test runtime and show the selected environment. PR checks includerewrite; the existing tag-only publish condition and build/test/pack/upload/push commands are preserved.Add a standalone
net8.0package consumer that compiles real network properties and executes a dirty-property serialization round trip. CI runs it after packing. Each run restores the exact local package version into a fresh cache, with source mapping requiring Cat.Network to come from the worktree's artifact feed.Validation:
dotnet --versionselected 10.0.400 through the new pin.fieldaccessors. C# 12 and C# 13 controls failed; the documented C# 14 configuration passed.rewritePR filter, and unchanged package upload/publication commands and tag guard.Runtime targets and package APIs remain unchanged (
net8.0runtime,netstandard2.0compiler extensions). SDK 10.0.400 is a tested baseline, not a claim that every earlier compiler is incompatible. Hosted GitHub Actions execution was not observed locally. The solution build retains one existing CS8600 warning inMemoryRelayTransport.cs.