Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review finding R29.
Copying the README's server storage example failed with CS0246 because it implemented the removed
IEntityStorageinterface. The replacement derives fromEntityStorage, implements the protected enumeration/add/remove hooks and public lookup/relevancy methods, and preserves the nullable lookup contract. The README explains the base-owned registration, ID assignment and relay attachment operations, and separates the class declaration from the setup statements.Add an external
tests/ReadmeStorageSmokeconsumer that compiles the complete documented storage implementation with all required runtime/analyzer/generator references. It checks that the compiled source matches the README and exercises registration, lookup, attachment before and after server construction, relevancy, relay replication, and removal through storage calls and client messages.Validation on .NET SDK 10.0.400:
dotnet run --project tests/ReadmeStorageSmoke/ReadmeStorageSmoke.csproj --configuration Release --no-restorepassed targeting .NET 8 with C# 14 and nullable warnings treated as errors in the consumer.dotnet test Cat.Network.Test/Cat.Network.Test.csproj --configuration Release --no-restore --verbosity minimalpassed all 155 existing runtime tests.git diff HEAD^ HEAD --checkpassed. The library's existing CS8600 warning atMemoryRelayTransport.cs:21remains.Compatibility: documentation and a standalone consumer fixture only; no production API, wire format, or dependency changes. The client smoke completes the existing handshake before spawning and is independent of the separate immediate-spawn fix.