You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pins vendor/crmedr and the Dockerfile's CRMEDR_REF to crmedr 39367d3 (head of crmedr #149, on top of the merged #147) and bumps the version to 0.18.8.
What it brings live:
crmedr Release 0.17.5 #147: the subject-identity pipeline scripts and 29 new automatic person items (Basil of Caesarea on 2 January, Telemachus/Almachius, René Lego, Padre Pio, Popes Leo II, Benedict II and XI, …).
Checks: uv run pytest 490 passed; smoke test on the vendored data — /api/v1/elogium/mr:0102-basilius-magnus-et-gregorius-nazianzenus carries Q44258, mr:0101-almachius Q1115667, mr:0101-ioannes-et-renatus-lego Q2652595.
Merge crmedr #149 first (the pinned commit is its head, which stays in crmedr's history after the merge). Live only after a GitHub release v0.18.8 is published.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: be00aa04-1537-4260-b6c5-380205afeb0b
📥 Commits
Reviewing files that changed from the base of the PR and between a6e3b11 and dc42f4a.
⛔ Files ignored due to path filters: 1
uv.lock is excluded by !**/*.lock
📒 Files selected for processing: 4
Dockerfile
pyproject.toml
src/martyrology_api/__init__.py
vendor/crmedr
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The project version changed from 0.18.7 to 0.18.8. The Docker build’s default CRMEDR commit and the vendor subproject reference changed to the same commit.
Changes: Release updates
Layer / File(s)
Summary
Version and CRMEDR reference pyproject.toml, src/martyrology_api/__init__.py, Dockerfile, vendor/crmedr
The package version changed to 0.18.8. The Docker build’s default CRMEDR commit and the vendor subproject reference changed to 39367d37d4fadf3441f15a37e06214233e729e87.
This changes the CRMEDR revision used by the Docker build. The pinned commit is currently fetchable even though upstream PR #149 is open, so no concrete merge-blocking risk is established.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the 0.18.8 release and the pinned crmedr commit, which are the main changes in the pull request.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
vendor/crmedrand the Dockerfile'sCRMEDR_REFto crmedr 39367d3 (head of crmedr #149, on top of the merged #147) and bumps the version to 0.18.8.What it brings live:
Checks:
uv run pytest490 passed; smoke test on the vendored data —/api/v1/elogium/mr:0102-basilius-magnus-et-gregorius-nazianzenuscarries Q44258,mr:0101-almachiusQ1115667,mr:0101-ioannes-et-renatus-legoQ2652595.Merge crmedr #149 first (the pinned commit is its head, which stays in crmedr's history after the merge). Live only after a GitHub release v0.18.8 is published.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KqotW9VAW3NVLGt3a4fJ1w
Summary by CodeRabbit