Skip to content

Release 0.18.8: pin crmedr 39367d3 - #166

Merged
JohnRDOrazio merged 1 commit into
mainfrom
chore/release-0.18.8
Oct 19, 2026
Merged

JohnRDOrazio merged 1 commit into
mainfrom
chore/release-0.18.8

Conversation

@JohnRDOrazio

@JohnRDOrazio JohnRDOrazio commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Pins vendor/crmedr and the Dockerfile's CRMEDR_REF to crmedr 39367d3 (head of crmedr #149, on top of the merged #147) and bumps the version to 0.18.8.

What it brings live:

Checks: uv run pytest 490 passed; smoke test on the vendored data — /api/v1/elogium/mr:0102-basilius-magnus-et-gregorius-nazianzenus carries Q44258, mr:0101-almachius Q1115667, mr:0101-ioannes-et-renatus-lego Q2652595.

Merge crmedr #149 first (the pinned commit is its head, which stays in crmedr's history after the merge). Live only after a GitHub release v0.18.8 is published.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KqotW9VAW3NVLGt3a4fJ1w

Summary by CodeRabbit

  • Updates
    • Updated the bundled martyrology reference to a newer revision, keeping the data aligned with the latest included source.
    • This release is version 0.18.8.

…tomatic person items)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KqotW9VAW3NVLGt3a4fJ1w
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: be00aa04-1537-4260-b6c5-380205afeb0b
📥 Commits

Reviewing files that changed from the base of the PR and between a6e3b11 and dc42f4a.

⛔ Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing: 4
  • Dockerfile
  • pyproject.toml
  • src/martyrology_api/__init__.py
  • vendor/crmedr

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The project version changed from 0.18.7 to 0.18.8. The Docker build’s default CRMEDR commit and the vendor subproject reference changed to the same commit.

Changes: Release updates

Layer / File(s) Summary
Version and CRMEDR reference
pyproject.toml, src/martyrology_api/__init__.py, Dockerfile, vendor/crmedr
The package version changed to 0.18.8. The Docker build’s default CRMEDR commit and the vendor subproject reference changed to 39367d37d4fadf3441f15a37e06214233e729e87.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to dc42f

This changes the CRMEDR revision used by the Docker build. The pinned commit is currently fetchable even though upstream PR #149 is open, so no concrete merge-blocking risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the 0.18.8 release and the pinned crmedr commit, which are the main changes in the pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@JohnRDOrazio
JohnRDOrazio merged commit c75b8ff into main Oct 19, 2026
4 checks passed
@JohnRDOrazio
JohnRDOrazio deleted the chore/release-0.18.8 branch October 19, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants