Skip to content

CATROID-1106: GlideToPositionBrick - #5239

Open
rinaschedl wants to merge 7 commits into
Catrobat:developfrom
rinaschedl:Catroid-1106
Open

CATROID-1106: GlideToPositionBrick#5239
rinaschedl wants to merge 7 commits into
Catrobat:developfrom
rinaschedl:Catroid-1106

Conversation

@rinaschedl

@rinaschedl rinaschedl commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

https://catrobat.atlassian.net/browse/CATROID-1106

A new Brick (Feature) is created.
Brick Behavior:
The Brick has 3 options:
-random position
- the sprite glides to a random position
-touch position
- the player has to touch a position where the sprite then goes
-other sprite position
- the sprite glides (and at the moment follows) a other sprite till the other sprite stops.
- this part is not finally discussed: may we change it so that the sprite goes to the startposition from the other sprite and don't follow at all.

Program changes:
create 3 Actions and 3 Actionstest, GlideToPositionBrick, brick_glide_to_position
changes in BrickValue, ActionFactory

Commitlist during coding:
TestGlideToRandomPositionDestination Test; flact:red
TestGlideToRandomPositionDestination flact:green; createGlidetoRandomPositionAction;
Refactoring and knew Test: GlideBehavior, bove Tests are green
show Brick in Bricklist with the correct attributs. Attributes don't work yet.
changed all glide_to_.... to glide_to_position_... so to better distinguish between.
last commit before PairProgramming Session with Thomas
glideToTouchPosition ready, brick test by hand and the tests are grenn
refactor the ActionTest: canceled all deprecated lines; correct misspellings;
add GlideToOtherSpritePosition
refactor GlideToRandomPositionAction.kt
Refactoring all files that changed in the ticket Catroid-1106

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@@ -0,0 +1,75 @@
<?xml version="1.0" encoding="utf-8"?>

<!--

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@hannesweilharter

Copy link
Copy Markdown
Contributor

please fix all warnings first and have a look at the Unit Test Report, there are failing testcases. Not sure if they are related to these changes. Then i can do a review :)

@hannesweilharter hannesweilharter added the Active Member Tickets that are assigned to members that are still currently active label Aug 23, 2026
A new Brick (Feature) is created.
The Brick has 3 options:
-random position
	- the sprite glides to a random position
-touch position
	- the player has to touch a position where the sprite then goes
-other sprite position
	- the sprite glides and at the moment follows a other sprite
	  till the other sprite stops.
	- this part is not finally discussed: may we change it so that
	  the sprite goes to the startposition from the other sprite, if
	  it moves too

TestGlideToRandomPositionDestination Test; flact:red

TestGlideToRandomPositionDestination flact:green; createGlidetoRandomPositionAction;

Refactoring and knew Test: GlideBehavior, bove Tests are green

show Brick in Bricklist with the correct attributs. Attributes don't work yet.

changed all glide_to_.... to glide_to_position_... so to better distinguish between.

last commit before PairProgramming Session with Thomas

glideToTouchPosition ready, brick test by hand and the tests are grenn

refactor the ActionTest: canceled all deprecated lines; correct misspellings;

add GlideToOtherSpritePosition

refactor GlideToRandomPositionAction.kt

Refactoring all files that changed in the ticket Catroid-1106

Refactoring all files that changed in the ticket Catroid-1106
…sts suddently failed and we do not have a koin base class
…ction for the GlideToPosition actions. Warnings of deprecated stays in the ActionFactory
…ction for the GlideToPosition actions. Warnings of deprecated stays in the ActionFactory
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@rinaschedl

Copy link
Copy Markdown
Contributor Author

@hannesweilharter please start with CodeReview.
the issue on the Quality Gate is discussed with Thomas and I shall ingnore it for now. There will be a ticket for the Action Faktory because to change the warnings, you have also some changing to the Unit Tests necessary and the workload is relativly high, therefor we changed the ActionFactory back, so you see the warnings but the tests mostly pass now. The 2 failing Tests has nothing to too with the changes I made in the code, so far I can see, so I guess there one of the flanky ones? Lokal all Tests passed, exept some of them who Thomas confirmed are broken. So we should be good.
Thanks
Katharina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants