PAINTROID-796 Add Clip area tool - #132
Conversation
6bf321f to
73fd9cc
Compare
|
@Amit-Matth Please regenerate the conflicted file |
fe21f0b to
18dd11e
Compare
|
@juliajulie95 PR is ready for review now. |
18dd11e to
3c72edf
Compare
|
In the native version the dashed line has a black border, so that when you still have the same color selecting you drew with, you still see exactly where you selected. Everything else looks fine! Thank you |
Thanks for the suggestion! I’ve already added the black border to the dashed selection line to match the native version and pushed the changes. |
|
There are new merge conflicts, due to merging your other ticket, please resolve |
|
I let AI run over the code and it found some issues, please check.
Smaller structural note: Android closes the area by mutating the path once in handleUp (quadTo(coordinate, initialCoordinate)) and rejects a bare tap outright. Doing that instead of deferring the closing line to ClipPathCommand.call via startPoint/endPoint would remove the isEffectivelySingleTap branch and ~40 lines from onUp — and the two params are currently passed inverted (startPoint: currentEndPoint, endPoint: _startPoint), which is confusing. |
|
I've finished the Clipping Tool alignment. The main change was moving the preview logic out of the Command stack and into Thanks for the detailed review! It was really helpful and gave me a much clearer direction on what needed to be fixed. |
This PR introduces the Clip Area Tool, which works as a crop-like feature for the canvas.
PAINTROID-796
New Features and Enhancements
This provides users with an intuitive way to crop their artwork to a custom shape, matching the functionality of the native app.
Refactorings and Bug Fixes
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.