Skip to content

[PAINTROID-809] Fix hidden help menu buttons - #169

Open
Knist1704 wants to merge 3 commits into
Catrobat:developfrom
Knist1704:PAINTROID-809
Open

[PAINTROID-809] Fix hidden help menu buttons#169
Knist1704 wants to merge 3 commits into
Catrobat:developfrom
Knist1704:PAINTROID-809

Conversation

@Knist1704

Copy link
Copy Markdown
Contributor

Navigation in help screen no longer hidden behind system nav bar or 3 button navigation
Jira Link

Refactorings and Bug Fixes

  • Refactored from prebuilt widget to custom
  • Navigation buttons visible

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

@juliajulie95

Copy link
Copy Markdown
Contributor

Spray tool test is failing, please chec why and either fix the implementation or the test + describe why if you change the test

@Knist1704

Copy link
Copy Markdown
Contributor Author

The spray tool is spraying within double the given radius, the color check afterwards was only in 1x the radius, plus the fact that some point may lie outside the canvas. The chance for non of the sprayed pixels being inside the smaller checked circle was higher, therefore failing the testcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants