[PAINTROID-809] Fix hidden help menu buttons - #169
Open
Knist1704 wants to merge 3 commits into
Open
Conversation
Contributor
|
Spray tool test is failing, please chec why and either fix the implementation or the test + describe why if you change the test |
Knist1704
force-pushed
the
PAINTROID-809
branch
from
August 10, 2026 09:23
e74e6a9 to
0c12357
Compare
Knist1704
force-pushed
the
PAINTROID-809
branch
from
August 10, 2026 09:31
0c12357 to
5e1da6e
Compare
Contributor
Author
|
The spray tool is spraying within double the given radius, the color check afterwards was only in 1x the radius, plus the fact that some point may lie outside the canvas. The chance for non of the sprayed pixels being inside the smaller checked circle was higher, therefore failing the testcase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation in help screen no longer hidden behind system nav bar or 3 button navigation
Jira Link
Refactorings and Bug Fixes
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.